Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linker doesn't use correct TypeDefinition to determine if a method is needed as an override of an interface method #98255

Closed
jtschuster opened this issue Feb 10, 2024 · 1 comment · Fixed by #98274
Closed

Linker doesn't use correct TypeDefinition to determine if a method is needed as an override of an interface method #98255

jtschuster opened this issue Feb 10, 2024 · 1 comment · Fixed by #98274
Assignees
@jtschuster
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers

Comments

@jtschuster
Copy link
Member

See #97487 (comment) for more details.

There could be a method on a base type that provides an implementation for an interface implementation. Using that type as the "Implementing type" is incorrect, but will lead to correct results because the method will be kept if the "Implementing type" is marked as instantiated, and because all base types are marked as instantiated if the derived type is.
@jtschuster jtschuster added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Feb 10, 2024
@jtschuster jtschuster self-assigned this Feb 10, 2024
@ghost
Copy link

ghost commented Feb 10, 2024

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

See #97487 (comment) for more details.

There could be a method on a base type that provides an implementation for an interface implementation. Using that type as the "Implementing type" is incorrect, but will lead to correct results because the method will be kept if the "Implementing type" is marked as instantiated, and because all base types are marked as instantiated if the derived type is.

Author: jtschuster
Assignees: jtschuster
Labels:

area-Tools-ILLink
Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 10, 2024
@jtschuster jtschuster changed the title Linker doesn't use correct type to determine if a method is needed as an override of an interface method Linker doesn't use correct TypeDefinition to determine if a method is needed as an override of an interface method Feb 10, 2024
@jtschuster jtschuster removed the untriaged New issue has not been triaged by the area owner label Feb 10, 2024
@jtschuster jtschuster mentioned this issue Feb 11, 2024
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 11, 2024
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jtschuster jtschuster

Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Projects
AppModel
Archived in project
Milestone
No milestone
1 participant
@jtschuster