Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade #110477

Merged
merged 41 commits into from
Dec 16, 2024
Merged

[main] Update dependencies from dotnet/arcade #110477

merged 41 commits into from
Dec 16, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 6, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20241213.2
  • Date Produced: December 13, 2024 7:51:52 PM UTC
  • Commit: 255d5e0c89958af276883a988108c2d616438805
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20241…
db1fb6f 
…205.6

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.24605.1 -> To Version 10.0.0-beta.24605.6
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Dec 6, 2024
@akoeplinger
Copy link
Member

@dotnet/illink three linker tests are failing with this bump:

  • DataFlow.NullableAnnotations
  • BCLFeatures.ETW.CustomEventSource
  • UnreachableBlock.ComplexConditions

@akoeplinger
Copy link
Member

@dotnet/ilc-contrib ILC fails to compile crossgen2 on windows x86:

  crossgen2_publish -> D:\a\_work\1\s\artifacts\bin\crossgen2_publish\x86\Checked\crossgen2.dll
  Generating native code
EXEC : error : One or more errors occurred. (Code generation failed for method '[S.P.CoreLib]System.Numerics.BitOperations.TrailingZeroCount(uint64)') [D:\a\_work\1\s\src\coreclr\tools\aot\crossgen2\crossgen2_publish.csproj]
##[error]EXEC(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) One or more errors occurred. (Code generation failed for method '[S.P.CoreLib]System.Numerics.BitOperations.TrailingZeroCount(uint64)')
  System.AggregateException: One or more errors occurred. (Code generation failed for method '[S.P.CoreLib]System.Numerics.BitOperations.TrailingZeroCount(uint64)')
   ---> ILCompiler.CodeGenerationFailedException: Code generation failed for method '[S.P.CoreLib]System.Numerics.BitOperations.TrailingZeroCount(uint64)'
   ---> System.Collections.Generic.KeyNotFoundException: The given key 'Bmi1_X64' was not present in the dictionary.
     at ILCompiler.HardwareIntrinsicILProvider.GetMethodIL(MethodDesc) + 0x1ec
     at ILCompiler.SubstitutedILProvider.TryGetMethodConstantValue(MethodDesc, Int32&, Int32) + 0xc2
     at ILCompiler.SubstitutedILProvider.TryGetConstantArgument(MethodIL, Byte[], SubstitutedILProvider.OpcodeFlags[], Int32, Int32, Int32&) + 0x608
     at ILCompiler.SubstitutedILProvider.GetMethodILWithInlinedSubstitutions(MethodIL) + 0x1cf9
     at ILCompiler.SubstitutedILProvider.GetMethodIL(MethodDesc) + 0x60
     at ILCompiler.Compilation.CombinedILProvider.GetMethodIL(MethodDesc) + 0x21
     at ILCompiler.Compilation.ILCache.CreateValueFromKey(MethodDesc) + 0x3c
     at Internal.TypeSystem.LockFreeReaderHashtable`2.CreateValueAndEnsureValueIsInTable(TKey) + 0x18
     at ILCompiler.Compilation.GetMethodIL(MethodDesc) + 0xb6
     at Internal.IL.ILImporter..ctor(ILScanner, MethodDesc, MethodIL) + 0x55
     at ILCompiler.ILScanner.CompileSingleMethod(ScannedMethodNode) + 0x53
     --- End of inner exception stack trace ---
     at ILCompiler.ILScanner.CompileSingleMethod(ScannedMethodNode) + 0x128
     at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`2.<ForWorker>b__1(RangeWorker&, Int64, Boolean&) + 0x10d
  --- End of stack trace from previous location ---
     at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`2.<ForWorker>b__1(RangeWorker&, Int64, Boolean&) + 0x4e4
     at System.Threading.Tasks.TaskReplicator.Replica.Execute() + 0xb1
     --- End of inner exception stack trace ---
     at System.Threading.Tasks.TaskReplicator.Run[TState](TaskReplicator.ReplicatableUserAction`1, ParallelOptions, Boolean) + 0x2b2
     at System.Threading.Tasks.Parallel.ForWorker[TLocal,TInt](TInt, TInt, ParallelOptions, Action`1, Action`2, Func`4, Func`1, Action`1) + 0x21f
  --- End of stack trace from previous location ---
     at System.Threading.Tasks.Parallel.ThrowSingleCancellationExceptionOrOtherException(ICollection, CancellationToken, Exception) + 0x30
     at System.Threading.Tasks.Parallel.ForWorker[TLocal,TInt](TInt, TInt, ParallelOptions, Action`1, Action`2, Func`4, Func`1, Action`1) + 0x449
     at ILCompiler.ILScanner.CompileMultiThreaded(List`1) + 0x264
     at ILCompiler.ILScanner.ComputeDependencyNodeDependencies(List`1) + 0x153
     at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.ComputeMarkedNodes() + 0xa3
     at ILCompiler.ILScanner.ILCompiler.IILScanner.Scan() + 0x1b
     at ILCompiler.Program.<Run>g__RunScanner|4_0(Program.<>c__DisplayClass4_0&) + 0x1fa
     at ILCompiler.Program.Run() + 0x292b
     at ILCompiler.ILCompilerRootCommand.<>c__DisplayClass246_0.<.ctor>b__0(ParseResult) + 0x321
D:\a\_work\1\s\.packages\microsoft.dotnet.ilcompiler\10.0.0-alpha.1.24570.9\build\Microsoft.NETCore.Native.targets(315,5): error MSB3073: The command ""D:\a\_work\1\s\.packages\runtime.win-x64.microsoft.dotnet.ilcompiler\10.0.0-alpha.1.24570.9\tools\\ilc" @"D:\a\_work\1\s\artifacts\obj\coreclr\crossgen2_publish\windows.x86.Checked\native\crossgen2.ilc.rsp"" exited with code 1. [D:\a\_work\1\s\src\coreclr\tools\aot\crossgen2\crossgen2_publish.csproj]

@sbomer
Fix CustomEventSource test
497ed57 
#110001 updated annotations on
EventSource. This adjusts the expected preserved members to match.
@sbomer sbomer requested a review from marek-safar as a code owner December 6, 2024 19:13
@sbomer sbomer requested a review from a team December 6, 2024 19:13
@sbomer
Fix tests with Type checks
15a30ef 
With https://github.com/dotnet/runtime/pull/106497/files,
object.GetType is no longer an internalcall. This means we no longer
mark the ctor of the return type, System.Type, so the type check
removal optimization is kicking in where it didn't before.
@sbomer sbomer force-pushed the darc-main-9dbe0517-45a5-433c-8ef5-b5807629e7e2 branch from 06cab35 to 15a30ef Compare December 6, 2024 19:13
This was referenced Dec 6, 2024
Open
Open
Closed
Closed
Open
@jkotas
Copy link
Member

jkotas commented Dec 7, 2024

@dotnet/ilc-contrib ILC fails to compile crossgen2 on windows x86:

It should be fixed by #110238

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20241…
5c144c7 
…206.6

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.24605.1 -> To Version 10.0.0-beta.24606.6
@build-analysis build-analysis bot mentioned this pull request Dec 7, 2024
Open
@am11
Copy link
Member

am11 commented Dec 8, 2024

@dotnet/ilc-contrib ILC fails to compile crossgen2 on windows x86:

It should be fixed by #110238

It is blocked on dotnet/sdk#45042, which in turn is blocked on other things. We can disable nativeaot publishing on win-x86 after this line

runtime/eng/Subsets.props

Line 127 in 5ae9467

<UseNativeAotForComponents Condition="'$(NativeAotSupported)' == 'true' and '$(TargetOS)' == '$(HostOS)' and '$(TargetsLinuxBionic)' != 'true'">true</UseNativeAotForComponents>
to unblock this PR:

<!-- TODO: remove once SDK is updated to 10.0 preview 1 (needs https://github.com/dotnet/runtime/pull/110238) -->
<UseNativeAotForComponents Condition="'$(TargetOS)' == 'windows' and '$(TargetArchitecture)' == 'x86'">false</UseNativeAotForComponents>

@akoeplinger
Copy link
Member

I'm looking at the wasm failures.

@am11
Copy link
Member

am11 commented Dec 12, 2024

We can sync with main (#109069 is just merged).

dotnet-maestro bot and others added 10 commits December 12, 2024 13:08
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20241…
0787ae6 
…211.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.24605.1 -> To Version 10.0.0-beta.24611.4
@akoeplinger
Merge remote-tracking branch 'upstream/main' into darc-main-9dbe0517-…
0e05150 
…45a5-433c-8ef5-b5807629e7e2

# Conflicts:
#	src/mono/wasm/Wasm.Build.Tests/NonWasmTemplateBuildTests.cs
#	src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs
#	src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs
#	src/mono/wasm/Wasm.Build.Tests/TestMainJsTestBase.cs
@akoeplinger
Use feature switch to disable DataSet xml serialization related tests
a149938
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20241…
542380d 
…212.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.24605.1 -> To Version 10.0.0-beta.24612.4
@akoeplinger
Workload fixes and improvements
96bf283
@akoeplinger
Remove runtimes-windows from workload manifest, it is unused
c587848
@akoeplinger
Add net10 entries in workloads.csproj
c33f055
@akoeplinger
Fix mistakes in net8 workload manifest
a2b10a0
@akoeplinger
Update emsdk
5f83c2c
@akoeplinger
Fix msbuild conditions
bbdd012
This was referenced Dec 14, 2024
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20241…
64e62f9 
…213.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.24605.1 -> To Version 10.0.0-beta.24613.2
@build-analysis build-analysis bot mentioned this pull request Dec 14, 2024
Open
@am11 am11 mentioned this pull request Dec 16, 2024
Open
This was referenced Dec 16, 2024
Open
Open
Open
@akoeplinger
Copy link
Member

/ba-g OOM in the browser-wasm linux Release LibraryTests_Threading job is unrelated

@akoeplinger akoeplinger merged commit 373f048 into main Dec 16, 2024
157 of 159 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-9dbe0517-45a5-433c-8ef5-b5807629e7e2 branch December 16, 2024 18:52
@ivanpovazan ivanpovazan mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@akoeplinger @jkotas @am11 @ViktorHofer @sbomer @MichalStrehovsky @jkoritzinsky