[cdac] Fix ISOSDacInterface13.TraverseLoaderHeap parameter type
#110678
+2
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon |
| [GeneratedComInterface] | ||
| [Guid("3176a8ed-597b-4f54-a71f-83695c6a8c5e")] | ||
| internal unsafe partial interface ISOSDacInterface13 | ||
| { | ||
| [PreserveSig] | ||
| int TraverseLoaderHeap(ulong loaderHeapAddr, /*LoaderHeapKind*/ int kind, VISITHEAP pCallback); | ||
| int TraverseLoaderHeap(ulong loaderHeapAddr, /*LoaderHeapKind*/ int kind, /*VISITHEAP*/ delegate* unmanaged<ulong, nuint, Interop.BOOL> pCallback); |
There was a problem hiding this comment.
So the nuint here is size_t in C++. This means if the cdac is reading a 32-bit DMP, it will be wrong if the reader process is 64-bit. Have we thought about this issue? Entirely possible this is a known limitation of the cdac.
There was a problem hiding this comment.
For actually reading from the target, we have TargetNUInt and we will read the appropriate size based on the target. For the APIs that a consumer (like SOS) calls, the consumer should have the same bitness of the cDAC?
AaronRobinsonMSFT
changed the title
ISOSDacInterface13.TraverseLoaderHeap paramater typeISOSDacInterface13.TraverseLoaderHeap parameter type
AaronRobinsonMSFT
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VISITHEAPparameter is a function pointer, not a struct. I must have just completely failed at reading when I wrote that...Found this while running the diagnostics repo SOS tests with the cDAC enabled and a debug cdacreader. I was trying to check that #110602 should finish out what is needed for
GetMethodDescData. There's still one more issue I'm investigating where we end up with as a method name because our method desc validation (incorrectly) fails.Contributes to #99302