From bf3fa72fc71299ec29dafb8f1ec2dc7ad90c6491 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Sat, 28 Mar 2020 06:58:48 +0100 Subject: [PATCH] Move OSR related APIs to Common Also unifying the style with the others that just throw. --- .../tools/Common/JitInterface/CorInfoImpl.cs | 4 ++++ .../JitInterface/CorInfoImpl.ReadyToRun.cs | 18 ------------------ 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/src/coreclr/src/tools/Common/JitInterface/CorInfoImpl.cs b/src/coreclr/src/tools/Common/JitInterface/CorInfoImpl.cs index 5dfeee4a7676e..a4b14861f737c 100644 --- a/src/coreclr/src/tools/Common/JitInterface/CorInfoImpl.cs +++ b/src/coreclr/src/tools/Common/JitInterface/CorInfoImpl.cs @@ -903,6 +903,10 @@ private bool satisfiesMethodConstraints(CORINFO_CLASS_STRUCT_* parent, CORINFO_M { throw new NotImplementedException("satisfiesMethodConstraints"); } private bool isCompatibleDelegate(CORINFO_CLASS_STRUCT_* objCls, CORINFO_CLASS_STRUCT_* methodParentCls, CORINFO_METHOD_STRUCT_* method, CORINFO_CLASS_STRUCT_* delegateCls, ref bool pfIsOpenDelegate) { throw new NotImplementedException("isCompatibleDelegate"); } + private void setPatchpointInfo(PatchpointInfo* patchpointInfo) + { throw new NotImplementedException("setPatchpointInfo"); } + private PatchpointInfo* getOSRInfo(ref uint ilOffset) + { throw new NotImplementedException("getOSRInfo"); } private void methodMustBeLoadedBeforeCodeIsRun(CORINFO_METHOD_STRUCT_* method) { diff --git a/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs b/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs index 08c0b884e5c85..1f477b034bb58 100644 --- a/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs +++ b/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs @@ -2178,24 +2178,6 @@ private void getGSCookie(IntPtr* pCookieVal, IntPtr** ppCookieVal) *ppCookieVal = (IntPtr *)ObjectToHandle(_compilation.NodeFactory.GetReadyToRunHelperCell(ReadyToRunHelper.GSCookie)); } - /// - /// Record patchpoint info for the method - /// - private void setPatchpointInfo(PatchpointInfo* patchpointInfo) - { - // No patchpoint info when prejitting - throw new NotImplementedException(); - } - - /// - /// Retrieve OSR info for the method - /// - private PatchpointInfo* getOSRInfo(ref uint ilOffset) - { - // No patchpoint info when prejitting - throw new NotImplementedException(); - } - private void getMethodVTableOffset(CORINFO_METHOD_STRUCT_* method, ref uint offsetOfIndirection, ref uint offsetAfterIndirection, ref bool isRelative) { throw new NotImplementedException("getMethodVTableOffset"); } private void expandRawHandleIntrinsic(ref CORINFO_RESOLVED_TOKEN pResolvedToken, ref CORINFO_GENERICHANDLE_RESULT pResult)