Update Mono's implementation of Vector<T> intrinsics. #39322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recognize `get_AllBitsSet` instead of `get_AllOnes`; this internal intrinsic was renamed in dotnet#36579 (1c66ad1). Implement Vector<T>.One as an intrinsic.
imhameed
requested review from
alexischr,
CoffeeFlux,
lambdageek,
SamMonoRT and
vargaz
as code owners
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
lambdageek
added
area-Codegen-JIT-mono
and removed
area-CodeGen-coreclr
|
Tagging subscribers to this area: @lewurm |
vargaz
approved these changes
Jul 15, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recognize
get_AllBitsSetinstead ofget_AllOnes; this internalintrinsic was renamed in #36579
(1c66ad1).
Implement
Vector<T>.Oneas an intrinsic.See also: #38718