Add arch info in missing framework error #57150
Conversation
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsAdds the architecture information for missing framework errors.
|
| string expectedUrlQuery; | ||
| string expectedUrlParameter = null; | ||
| string expectedStdErr = null; | ||
| int expectedErrorCode = 0; |
There was a problem hiding this comment.
Any reason this variable moved down?
There was a problem hiding this comment.
There was no particular reason for moving the declaration order I can change it back. The variable was declared but nothing in the test was checking that the actual exit code was the one expected.
src/installer/tests/HostActivation.Tests/PortableAppActivation.cs
Outdated
Show resolved
Hide resolved
| .Should().Fail() | ||
| .And.HaveStdErrContaining($"- https://aka.ms/dotnet-core-applaunch?{expectedUrlQuery}") | ||
| .And.HaveStdErrContaining(expectedStdErr) | ||
| .And.ExitWith(expectedErrorCode); |
There was a problem hiding this comment.
I don't think this will work properly on some (Unix) systems where the exit codes are 0-255
| string expectedUrlQuery; | ||
| string expectedUrlParameter = null; | ||
| string expectedStdErr = null; |
There was a problem hiding this comment.
Can you also change the name of this test ErrorReportedInDialog -> ErrorReportedInStdErr?
|
While we're here, can we also include the version in the download URL? Something like |
We already put the framework version on the URL, is this something different? A URL example would be: |
|
Nope that should be good enough. I just wanted to make sure we had some information that the site could use to narrow down the needed runtime. Do we have that for the case where there is no runtime, or only when there's a missing framework? |
|
Yes. For missing runtime we put the arch, the rid and the apphost version. E.g., |
ghost
locked as resolved and limited conversation to collaborators
Adds the architecture information for missing framework errors.