From fcfdad2ef85c0d7a99a4ae2050fa8c50d3d724a3 Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Thu, 21 Apr 2022 12:36:45 -0600 Subject: [PATCH 1/2] Disable UnixCreateSetsPermissionsInExternalAttributes on Mac --- .../System.IO.Compression.ZipFile/tests/ZipFile.Unix.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Unix.cs b/src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Unix.cs index 23f667cdbf31f..2911c69eec75a 100644 --- a/src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Unix.cs +++ b/src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Unix.cs @@ -12,7 +12,8 @@ namespace System.IO.Compression.Tests public partial class ZipFile_Unix : ZipFileTestBase { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/60581", TestPlatforms.iOS | TestPlatforms.tvOS)] + // Disabled on Mac for https://github.com/dotnet/runtime/issues/68293 + [ActiveIssue("https://github.com/dotnet/runtime/issues/60581", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.OSX)] public void UnixCreateSetsPermissionsInExternalAttributes() { // '7600' tests that S_ISUID, S_ISGID, and S_ISVTX bits get preserved in ExternalAttributes From 3b04f44424f550c1ff32556dbf1c500f2d481661 Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Thu, 21 Apr 2022 14:06:16 -0600 Subject: [PATCH 2/2] feedback --- .../System.IO.Compression.ZipFile/tests/ZipFile.Unix.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Unix.cs b/src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Unix.cs index 2911c69eec75a..772b776f6de14 100644 --- a/src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Unix.cs +++ b/src/libraries/System.IO.Compression.ZipFile/tests/ZipFile.Unix.cs @@ -12,8 +12,8 @@ namespace System.IO.Compression.Tests public partial class ZipFile_Unix : ZipFileTestBase { [Fact] - // Disabled on Mac for https://github.com/dotnet/runtime/issues/68293 - [ActiveIssue("https://github.com/dotnet/runtime/issues/60581", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.OSX)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/68293", TestPlatforms.OSX)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/60581", TestPlatforms.iOS | TestPlatforms.tvOS)] public void UnixCreateSetsPermissionsInExternalAttributes() { // '7600' tests that S_ISUID, S_ISGID, and S_ISVTX bits get preserved in ExternalAttributes