From 6909de38783b924208f3bc8ac7c96bcfc01e5649 Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Fri, 5 Aug 2022 14:40:02 -0500 Subject: [PATCH 1/2] Remove active issues for https://github.com/dotnet/runtime/issues/57506 --- .../System.Net.Requests/tests/HttpWebRequestTest.cs | 2 -- .../tests/FunctionalTests/AssemblyInfo.cs | 3 +-- .../tests/AssemblyInfo.cs | 7 ------- .../tests/AssemblyInfo.cs | 8 -------- .../CertificateCreation/CertificateRequestChainTests.cs | 1 - .../tests/ChainTests.cs | 1 - .../tests/CollectionTests.cs | 2 -- .../tests/DynamicChainTests.cs | 1 - .../tests/FindTests.cs | 1 - .../tests/X509StoreTests.cs | 1 - 10 files changed, 1 insertion(+), 26 deletions(-) delete mode 100644 src/libraries/System.Security.Cryptography.Pkcs/tests/AssemblyInfo.cs delete mode 100644 src/libraries/System.Security.Cryptography.X509Certificates/tests/AssemblyInfo.cs diff --git a/src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs b/src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs index 397520164eb56..a6939061bdca2 100644 --- a/src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs +++ b/src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs @@ -24,14 +24,12 @@ namespace System.Net.Tests { using Configuration = System.Net.Test.Common.Configuration; - [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))] public sealed class HttpWebRequestTest_Async : HttpWebRequestTest { public HttpWebRequestTest_Async(ITestOutputHelper output) : base(output) { } protected override Task GetResponseAsync(HttpWebRequest request) => request.GetResponseAsync(); } - [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))] public sealed class HttpWebRequestTest_Sync : HttpWebRequestTest { public HttpWebRequestTest_Sync(ITestOutputHelper output) : base(output) { } diff --git a/src/libraries/System.Net.Security/tests/FunctionalTests/AssemblyInfo.cs b/src/libraries/System.Net.Security/tests/FunctionalTests/AssemblyInfo.cs index 68b152e1c3bd4..9adf9f8c83536 100644 --- a/src/libraries/System.Net.Security/tests/FunctionalTests/AssemblyInfo.cs +++ b/src/libraries/System.Net.Security/tests/FunctionalTests/AssemblyInfo.cs @@ -5,5 +5,4 @@ using Xunit; [assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/34690", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] -[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))] -[assembly: SkipOnPlatform(TestPlatforms.Browser, "System.Net.Security is not supported on Browser")] \ No newline at end of file +[assembly: SkipOnPlatform(TestPlatforms.Browser, "System.Net.Security is not supported on Browser")] diff --git a/src/libraries/System.Security.Cryptography.Pkcs/tests/AssemblyInfo.cs b/src/libraries/System.Security.Cryptography.Pkcs/tests/AssemblyInfo.cs deleted file mode 100644 index 6c1e2b4a7ea83..0000000000000 --- a/src/libraries/System.Security.Cryptography.Pkcs/tests/AssemblyInfo.cs +++ /dev/null @@ -1,7 +0,0 @@ -// Licensed to the .NET Foundation under one or more agreements. -// The .NET Foundation licenses this file to you under the MIT license. - -using System; -using Xunit; - -[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))] \ No newline at end of file diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/AssemblyInfo.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/AssemblyInfo.cs deleted file mode 100644 index d338fa7711ae4..0000000000000 --- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/AssemblyInfo.cs +++ /dev/null @@ -1,8 +0,0 @@ - -// Licensed to the .NET Foundation under one or more agreements. -// The .NET Foundation licenses this file to you under the MIT license. - -using System; -using Xunit; - -[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/57810", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))] diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/CertificateCreation/CertificateRequestChainTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/CertificateCreation/CertificateRequestChainTests.cs index 615d86cb65fb3..a400697dd4610 100644 --- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/CertificateCreation/CertificateRequestChainTests.cs +++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/CertificateCreation/CertificateRequestChainTests.cs @@ -7,7 +7,6 @@ namespace System.Security.Cryptography.X509Certificates.Tests.CertificateCreation { - [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))] public static class CertificateRequestChainTests { public static bool PlatformSupportsPss { get; } = DetectPssSupport(); diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs index 614ae070496cc..bf0b9e230a169 100644 --- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs +++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs @@ -11,7 +11,6 @@ namespace System.Security.Cryptography.X509Certificates.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))] public static class ChainTests { private static bool TrustsMicrosoftDotComRoot diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/CollectionTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/CollectionTests.cs index df5c022b9fcc9..73c00e0dd4376 100644 --- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/CollectionTests.cs +++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/CollectionTests.cs @@ -886,7 +886,6 @@ public static void X509CertificateCollectionCopyTo() } [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))] public static void X509ChainElementCollection_CopyTo_NonZeroLowerBound_ThrowsIndexOutOfRangeException() { using (var microsoftDotCom = new X509Certificate2(TestData.MicrosoftDotComSslCertBytes)) @@ -1302,7 +1301,6 @@ public static void X509Certificate2CollectionGetHashCode() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))] public static void X509ChainElementCollection_IndexerVsEnumerator() { using (var microsoftDotCom = new X509Certificate2(TestData.MicrosoftDotComSslCertBytes)) diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs index c90b43d52435b..489298ea58ec2 100644 --- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs +++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs @@ -12,7 +12,6 @@ namespace System.Security.Cryptography.X509Certificates.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))] public static class DynamicChainTests { private static X509Extension BasicConstraintsCA => new X509BasicConstraintsExtension( diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/FindTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/FindTests.cs index 4abcce87bc50e..a734da8b711ea 100644 --- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/FindTests.cs +++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/FindTests.cs @@ -231,7 +231,6 @@ public static void FindByValidThumbprint_ValidOnly(bool validOnly) } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))] [SkipOnPlatform(PlatformSupport.MobileAppleCrypto, "Root certificate store is not accessible")] public static void FindByValidThumbprint_RootCert() { diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/X509StoreTests.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/X509StoreTests.cs index c63d118117bb2..a10c0f48a442c 100644 --- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/X509StoreTests.cs +++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/X509StoreTests.cs @@ -426,7 +426,6 @@ public static void OpenMachineRootStore_Permissions(OpenFlags permissions, bool } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))] [SkipOnPlatform(PlatformSupport.MobileAppleCrypto, "Root certificate store is not accessible")] public static void MachineRootStore_NonEmpty() { From 85fa35925db138aaa8c85e156a89ffa57d3bfe37 Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Sun, 14 Aug 2022 23:02:28 -0500 Subject: [PATCH 2/2] Remove AssemblyInfo.cs references --- .../tests/System.Security.Cryptography.Pkcs.Tests.csproj | 1 - .../System.Security.Cryptography.X509Certificates.Tests.csproj | 1 - 2 files changed, 2 deletions(-) diff --git a/src/libraries/System.Security.Cryptography.Pkcs/tests/System.Security.Cryptography.Pkcs.Tests.csproj b/src/libraries/System.Security.Cryptography.Pkcs/tests/System.Security.Cryptography.Pkcs.Tests.csproj index 06c202b569efb..8523c0d8296ea 100644 --- a/src/libraries/System.Security.Cryptography.Pkcs/tests/System.Security.Cryptography.Pkcs.Tests.csproj +++ b/src/libraries/System.Security.Cryptography.Pkcs/tests/System.Security.Cryptography.Pkcs.Tests.csproj @@ -10,7 +10,6 @@ Link="CommonTest\System\Security\Cryptography\PlatformSupport.cs" /> - diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/System.Security.Cryptography.X509Certificates.Tests.csproj b/src/libraries/System.Security.Cryptography.X509Certificates/tests/System.Security.Cryptography.X509Certificates.Tests.csproj index f9ea150bfae71..f9b187cec4ee8 100644 --- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/System.Security.Cryptography.X509Certificates.Tests.csproj +++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/System.Security.Cryptography.X509Certificates.Tests.csproj @@ -20,7 +20,6 @@ -