From fea043edd5796febd4496e7fa7ff74c59cee5165 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 2 Oct 2023 16:08:57 -0400 Subject: [PATCH 1/3] CI: Don't trigger runtime pipelines on perf pipeline only changes --- .../common/evaluate-default-paths.yml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/eng/pipelines/common/evaluate-default-paths.yml b/eng/pipelines/common/evaluate-default-paths.yml index 57f5746ce2e26..a166206092e40 100644 --- a/eng/pipelines/common/evaluate-default-paths.yml +++ b/eng/pipelines/common/evaluate-default-paths.yml @@ -52,6 +52,14 @@ parameters: eng/testing/bump-chrome-version.proj eng/testing/ChromeVersions.props ] + _perf_pipeline_specific_only: [ + eng/pipelines/runtime-wasm-perf.yml + eng/pipelines/coreclr/perf*yml + eng/pipelines/coreclr/templates/perf-job.yml + eng/pipelines/coreclr/templates/*-perf-* + eng/pipelines/coreclr/templates/run-perf* + eng/testing/performance/* + ] # src/workloads is only used in runtime-official builds # where evaluate-paths is not used @@ -90,6 +98,7 @@ jobs: - ${{ parameters._const_paths._wasm_specific_only }} - ${{ parameters._const_paths._wasm_pipelines }} - ${{ parameters._const_paths._always_exclude }} + - ${{ parameters._const_paths._perf_pipeline_specific_only }} - subset: mono_excluding_wasm include: @@ -101,6 +110,7 @@ jobs: - ${{ parameters._const_paths._wasm_specific_only }} - ${{ parameters._const_paths._wasm_pipelines }} - ${{ parameters._const_paths._always_exclude }} + - ${{ parameters._const_paths._perf_pipeline_specific_only }} - eng/Version.Details.xml - docs/* @@ -130,6 +140,7 @@ jobs: - ${{ parameters._const_paths._wasm_specific_only }} - ${{ parameters._const_paths._wasm_pipelines }} - ${{ parameters._const_paths._always_exclude }} + - ${{ parameters._const_paths._perf_pipeline_specific_only }} - subset: runtimetests combined: true @@ -137,6 +148,7 @@ jobs: - src/tests/* exclude: - ${{ parameters._const_paths._wasm_specific_only }} + - ${{ parameters._const_paths._perf_pipeline_specific_only }} - subset: tools_illink include: @@ -160,6 +172,7 @@ jobs: - ${{ parameters._const_paths._wasm_specific_only }} - ${{ parameters._const_paths._wasm_pipelines }} - ${{ parameters._const_paths._always_exclude }} + - ${{ parameters._const_paths._perf_pipeline_specific_only }} # We have limited Apple Silicon testing capacity # We want PR testing on a narrower set of changes @@ -219,6 +232,7 @@ jobs: - ${{ parameters._const_paths._wasm_pipelines }} exclude: - ${{ parameters._const_paths._always_exclude }} + - ${{ parameters._const_paths._perf_pipeline_specific_only }} - subset: wasmdebuggertests combined: true @@ -234,6 +248,7 @@ jobs: exclude: - src/mono/nuget/* - ${{ parameters._const_paths._always_exclude }} + - ${{ parameters._const_paths._perf_pipeline_specific_only }} # wasm/runtimetests need to be run - subset: wasm_runtimetests @@ -252,6 +267,7 @@ jobs: - src/mono/wasm/Wasm.Build.Tests/* - ${{ parameters._const_paths._wasm_pipelines }} - ${{ parameters._const_paths._always_exclude }} + - ${{ parameters._const_paths._perf_pipeline_specific_only }} # Wasm except Wasm.build.Tests, and debugger - subset: wasm_specific_except_wbt_dbg @@ -272,6 +288,7 @@ jobs: - src/mono/nuget/Microsoft.NET.Workload* - src/mono/nuget/Microsoft.NETCore.BrowserDebugHost.Transport/* - ${{ parameters._const_paths._always_exclude }} + - ${{ parameters._const_paths._perf_pipeline_specific_only }} - subset: wasm_chrome include: @@ -284,6 +301,7 @@ jobs: - ${{ parameters._const_paths._wasm_specific_only }} - ${{ parameters._const_paths._wasm_pipelines }} - ${{ parameters._const_paths._always_exclude }} + - ${{ parameters._const_paths._perf_pipeline_specific_only }} - eng/testing/tests.mobile.targets - src/mono/* - src/tasks/AndroidAppBuilder/* From 1b5e14fa96fd7ddd56e20ecd9116143db1126648 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 2 Oct 2023 16:16:42 -0400 Subject: [PATCH 2/3] dummy change --- eng/pipelines/coreclr/templates/run-performance-job.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/pipelines/coreclr/templates/run-performance-job.yml b/eng/pipelines/coreclr/templates/run-performance-job.yml index 794659045388c..77c27e8edf540 100644 --- a/eng/pipelines/coreclr/templates/run-performance-job.yml +++ b/eng/pipelines/coreclr/templates/run-performance-job.yml @@ -26,7 +26,7 @@ parameters: javascriptEngine: 'NoJS' helixTypeSuffix: '' # optional -- appends to HelixType collectHelixLogsScript: '' # optional -- script to collect the logs, and artifacts helpful for debugging failures - additionalSetupParameters: '' # optional -- additional setup parameters that are job-specific + additionalSetupParameters: '' # optional -- additional setup parameters that are job-specific -dummy jobs: - template: xplat-pipeline-job.yml From ae26fe522d59a3ca66aed880dd5bb29402c45776 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Tue, 3 Oct 2023 13:07:02 -0400 Subject: [PATCH 3/3] address review feedback from @ cincuranet --- eng/pipelines/common/evaluate-default-paths.yml | 2 +- eng/pipelines/coreclr/templates/run-performance-job.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/pipelines/common/evaluate-default-paths.yml b/eng/pipelines/common/evaluate-default-paths.yml index a166206092e40..26b3c1303adea 100644 --- a/eng/pipelines/common/evaluate-default-paths.yml +++ b/eng/pipelines/common/evaluate-default-paths.yml @@ -54,7 +54,7 @@ parameters: ] _perf_pipeline_specific_only: [ eng/pipelines/runtime-wasm-perf.yml - eng/pipelines/coreclr/perf*yml + eng/pipelines/coreclr/perf*.yml eng/pipelines/coreclr/templates/perf-job.yml eng/pipelines/coreclr/templates/*-perf-* eng/pipelines/coreclr/templates/run-perf* diff --git a/eng/pipelines/coreclr/templates/run-performance-job.yml b/eng/pipelines/coreclr/templates/run-performance-job.yml index 77c27e8edf540..794659045388c 100644 --- a/eng/pipelines/coreclr/templates/run-performance-job.yml +++ b/eng/pipelines/coreclr/templates/run-performance-job.yml @@ -26,7 +26,7 @@ parameters: javascriptEngine: 'NoJS' helixTypeSuffix: '' # optional -- appends to HelixType collectHelixLogsScript: '' # optional -- script to collect the logs, and artifacts helpful for debugging failures - additionalSetupParameters: '' # optional -- additional setup parameters that are job-specific -dummy + additionalSetupParameters: '' # optional -- additional setup parameters that are job-specific jobs: - template: xplat-pipeline-job.yml