Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementations for MakePointerType(), MakeArrayType() for GenericTypeParameterBuilder #97350

Merged
merged 15 commits into from
Feb 8, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added comment was not saved with previous commit
  • Loading branch information
buyaa-n committed Feb 8, 2024
commit 373889163ef19afcabd2403e9c8e6683c06d7c8e
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,7 @@ private void AddDefaultValue(EntityHandle parentHandle, object? defaultValue)
Type type = defaultValue.GetType();
if (type.IsEnum)
{
// ECMA spec II.22.9: in case of enum the constant type shall match the underlying type of that enum.
defaultValue = Convert.ChangeType(defaultValue, type.GetEnumUnderlyingType());
buyaa-n marked this conversation as resolved.
Show resolved Hide resolved
}
}
Expand Down
Loading