Regression in nuget restore for sfproj from sdk31 -> sdk60 #17671

ghost · 2021-05-17T20:08:46Z

Doing a trial run of building our repo on dotnetsdk 6.0 preview 3, and getting restore failures in a few projects. Self contained repro attached. Note that we're currently on latest LTS sdk: 3.1.409.

It appears that dotnet restore is not processing TargetFramework correctly in 6.0 inside an old-style project (e.g. sfproj), when that sfproj has been converted to use PackageReference instead of packages.config.

This is a regression from previous (LTS) version.

Minimal repro

git clone https://github.com/aaronla-ms/bug-repros.git
cd repro-dotnetsdk6
setup.cmd
repro.cmd

expected

restore succeeds on both dotnetsdk31 and dotnetsdk60

actual

restore fails on just dotnetsdk60. Error message as follows:

Determining projects to restore...
C:\repos\aaronla-ms\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj : error NU1202: Package Bond.Core.CSharp 9.0.3 is not compatible with net40 (.NETFramework,Version=v4.0). Package Bond.Core.CSharp 9.0.3 supports:
C:\repos\aaronla-ms\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj : error NU1202: - net45 (.NETFramework,Version=v4.5)
C:\repos\aaronla-ms\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj : error NU1202: - net46 (.NETFramework,Version=v4.6)
C:\repos\aaronla-ms\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj : error NU1202: - netstandard1.0 (.NETStandard,Version=v1.0)
C:\repos\aaronla-ms\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj : error NU1202: - netstandard1.3 (.NETStandard,Version=v1.3)
C:\repos\aaronla-ms\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj : error NU1202: - netstandard1.6 (.NETStandard,Version=v1.6)

It appears that nuget.targets is incorrectly determining the project to be net40, when the project does have TargetFramework=net462 set.

versions

[git: main]
aaronla@aaronla-r:repro-dotnetsdk6$ packages\dotnetsdk31\dotnet.exe --version
3.1.409

[git: main]
aaronla@aaronla-r:repro-dotnetsdk6$ packages\dotnetsdk60\dotnet.exe --version
6.0.100-preview.3.21202.5

[git: main]
aaronla@aaronla-r:repro-dotnetsdk6$ ver

Microsoft Windows [Version 10.0.19043.985]

The text was updated successfully, but these errors were encountered:

dotnet-issue-labeler · 2021-05-17T20:08:49Z

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

rainersigwald · 2021-05-17T21:02:51Z

A few notes on this project:

It doesn't use Microsoft.NET.SDK, but it does depend on NuGet functionality (package restore) that's intended to be consumed from there.
https://github.com/aaronla-ms/bug-repros/blob/main/ServiceFabricOnDotnetSdk.props has a bunch of workarounds for that. Presumably something changed to make them insufficient.

In the restore-task invocation I see this diff (left is 3.1, right is 6.0-preview):

-        Restoring packages for .NETFramework,Version=v4.6.2...
+        Restoring packages for .NETFramework,Version=v4.0...

Here's a diff of restore graph items, showing that the net462 TF is not present in the project item on the newer SDK.

--- 
+++ 
@@ -1,17 +1,18 @@
 RestoreTask
-    Assembly = C:\Program Files\dotnet\sdk\3.1.115\NuGet.Build.Tasks.dll
+    Assembly = C:\Program Files\dotnet\sdk\6.0.100-preview.4.21255.9\NuGet.Build.Tasks.dll
     Parameters
         RestoreGraphItems
-            cea5f56c-bbbf-4a39-8574-ac275eb5dfd5
+            eae28bfa-4ee8-4396-a66c-631b9153661e
                 MSBuildSourceProjectFile = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
                 MSBuildSourceTargetName = _IsProjectRestoreSupported
                 OriginalItemSpec = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
                 ProjectUniqueName = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
                 Type = RestoreSpec
-            93543f6a-5023-4678-958c-92c8d1cf111e
+            f8a6c2ba-0dc3-452d-9132-bf850da8376b
+                _CentralPackageVersionsEnabled = 
                 ConfigFilePaths = S:\work\bug-repros\repro-dotnetsdk6\NuGet.Config;C:\Users\raines\AppData\Roaming\NuGet\NuGet.Config;C:\Program Files (x86)\NuGet\Config\Microsoft.VisualStudio.FallbackLocation.config;C:\Program Files (x86)\NuGet\Config\Microsoft.VisualStudio.Offline.config
                 CrossTargeting = 
                 FallbackFolders = C:\Program Files (x86)\Microsoft Visual Studio\Shared\NuGetPackages
                 MSBuildSourceProjectFile = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
                 MSBuildSourceTargetName = _IsProjectRestoreSupported
                 NoWarn = 
@@ -27,42 +28,50 @@
                 RestoreLockedMode = 
                 RestorePackagesWithLockFile = 
                 RuntimeIdentifiers = ;
                 RuntimeSupports = 
                 SkipContentFileWrite = 
                 Sources = https://api.nuget.org/v3/index.json
-                TargetFrameworks = net462
                 TreatWarningsAsErrors = 
                 Type = ProjectSpec
                 ValidateRuntimeAssets = false
                 Version = 1.0.0
                 WarningsAsErrors = 
-            d045f94f-b4d1-4851-beae-c1509d60e4db
+            98a4f583-0429-4c9e-9df9-1daa100f7f36
                 GeneratePathProperty = true
                 Id = Microsoft.VisualStudio.Azure.Fabric.MSBuild
                 MSBuildSourceProjectFile = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
                 MSBuildSourceTargetName = _IsProjectRestoreSupported
                 OriginalItemSpec = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
                 ProjectUniqueName = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
                 TargetFrameworks = net462
                 Type = Dependency
                 VersionRange = 1.7.3
-            e144e66a-1c49-4caa-9b5f-f1671429a9bf
+            87a170ec-f7c8-4293-b4b8-3f8487b3ab01
                 Id = Bond.Core.CSharp
                 MSBuildSourceProjectFile = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
                 MSBuildSourceTargetName = _IsProjectRestoreSupported
                 OriginalItemSpec = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
                 ProjectUniqueName = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
                 TargetFrameworks = net462
                 Type = Dependency
                 VersionRange = 9.0.3
-            9de9a081-f356-439c-a917-10b82d5993fd
+            fe4e4461-20f0-4fc7-8025-6f8e80a0b965
                 AssetTargetFallback = 
                 MSBuildSourceProjectFile = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
                 MSBuildSourceTargetName = _IsProjectRestoreSupported
                 OriginalItemSpec = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
                 PackageTargetFallback = 
                 ProjectUniqueName = S:\work\bug-repros\repro-dotnetsdk6\repro-dotnetsdk6.csproj
+                RuntimeIdentifierGraphPath = 
                 TargetFramework = net462
+                TargetFrameworkIdentifier = .NETFramework
+                TargetFrameworkMoniker = .NETFramework,Version=v4.0
+                TargetFrameworkProfile = 
+                TargetFrameworkVersion = v4.0
+                TargetPlatformIdentifier = Windows
+                TargetPlatformMinVersion = 
+                TargetPlatformMoniker = Windows,Version=7.0
+                TargetPlatformVersion = 7.0
                 Type = TargetFrameworkInformation
         RestoreRecursive = True
         HideWarningsAndErrors = False

@nkolev92, that ring any bells off the top of your head?

ghost · 2021-05-17T21:12:52Z

FYI, this issue also repros on Visual Studio 2019 Developer command prompt, so I don't think this is limited to dotnetsdk, where it worked find in Visual Studio 2017 Developer command prompt. Suspect regression in msbuild.

Notably, msbuild version is newer in both failing combinations.

Vs 2017 command prompt (works):

$ msbuild /version /nologo
15.9.21.664

Vs 2019 command prompt (fails):

msbuild /version /nologo
16.9.0.16703

Under dotnetsdk31 (works):

$ dotnet --version
3.1.409

$ dotnet msbuild -nologo -version
16.7.2.52901

Under dotnetsdk60 (fails):

$ dotnet --version
6.0.100-preview.3.21202.5

$ dotnet msbuild -nologo --version
16.10.0.18107

rainersigwald · 2021-05-17T21:16:34Z

NuGet/NuGet.Client#3548 looks related, which is a change in NuGet 5.8.

nkolev92 · 2021-05-17T21:17:55Z

This change is a consequence of NuGet/Home#9756 and NuGet/Home#9895.

To make .NET 5 work, NuGet and the SDK had to fix an inconsistency in what the source of truth for a framework is.

TargetFramework is a property that should be interpreted, so newer NuGet & SDK use TargetFrameworkMoniker as the source of truth.

In SDK based projects, the TargetFramework value gets automatically deconstructed into the monikers

sdk/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.TargetFrameworkInference.targets

Lines 52 to 56 in 5c1f151

    
           <PropertyGroup Condition="'$(TargetFramework)' != '' and ('$(TargetFrameworkIdentifier)' == '' or '$(TargetFrameworkVersion)' == '')"> 
        
             <TargetFrameworkIdentifier>$([MSBuild]::GetTargetFrameworkIdentifier('$(TargetFramework)'))</TargetFrameworkIdentifier> 
        
             <TargetFrameworkVersion>v$([MSBuild]::GetTargetFrameworkVersion('$(TargetFramework)', 2))</TargetFrameworkVersion> 
        
           </PropertyGroup>

nkolev92 · 2021-05-17T21:18:23Z

NuGet/NuGet.Client#3548 looks related, which is a change in NuGet 5.8.

Beat me by 43s :D
You are on spot, that's where the change happened.

ghost · 2021-05-17T21:32:35Z

@nkolev92 Thanks for taking a look! Do you know when the fix will become available? We have a workaround, but curious when we can remove it. net5.0, net6.0?

nkolev92 · 2021-05-17T21:57:52Z

@aaronla-ms

The fix was done in 5.8/.NET SDK 5.0.100 to use TargetFrameworkMoniker and not TargetFramework.
The project must specify TargetFrameworkMoniker and not just TargetFramework.

ghost · 2021-05-17T22:11:23Z

@nkolev92 Thanks for clarifying. If I understand correctly then, this regression is "by design"? We were only using TargetFramework since some existing docs indicated it was required and sufficient for enabling nuget restore.

nkolev92 · 2021-05-17T22:58:27Z

We were only using TargetFramework since some existing docs indicated it was required and sufficient for enabling nuget restore.

Yep, those docs are incorrect unfortunately.
It was an intentional breaking change.

If you still see docs suggesting that, I'd love to know which so we can try to fix them.

ghost · 2021-05-17T23:04:06Z

@nkolev92 Thanks, if I find them, will do.

Can you clarify which settings are required for old-style projects? Do they need to specify TargetFramework and TargetFrameworkVersion? Just TargetFrameworkVersion? Or more settings?

I ask because it looks like TargetFrameworkVersion is the only setting I have to set, but at the same time, in dotnetsdk31, it looked like TargetFramework was the only setting that needed to be set. I just want to get some clarification on how this is supposed to work.

Alternatively, are there any docs for this?

nkolev92 · 2021-05-18T01:08:14Z

Discussed offline:

TargetFrameworkMoniker is what NuGet reads.

All these props have default values, so it's possible that in some situations even setting 1 property such as TargetFrameworkVersion is sufficient to make everything work.

TargetFramework is not a property that NuGet parses, but the SDK can translate it into a valid TFM if the project is SDK based.

I'm not familiar with particular documentation around this topic.

dotnet-issue-labeler bot added the untriaged Request triage from a team member label May 17, 2021

marcpopMSFT assigned wli3 May 25, 2021

wli3 removed the untriaged Request triage from a team member label Jun 1, 2021

wli3 added this to the Discussion milestone Jun 1, 2021

wli3 removed their assignment Jun 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Regression in nuget restore for sfproj from sdk31 -> sdk60 #17671

Regression in nuget restore for sfproj from sdk31 -> sdk60 #17671

ghost commented May 17, 2021 •

edited by ghost

Loading

dotnet-issue-labeler bot commented May 17, 2021

rainersigwald commented May 17, 2021 •

edited

Loading

ghost commented May 17, 2021 •

edited by ghost

Loading

rainersigwald commented May 17, 2021

nkolev92 commented May 17, 2021

nkolev92 commented May 17, 2021

ghost commented May 17, 2021

nkolev92 commented May 17, 2021

ghost commented May 17, 2021

nkolev92 commented May 17, 2021

ghost commented May 17, 2021 •

edited by ghost

Loading

nkolev92 commented May 18, 2021

Regression in nuget restore for sfproj from sdk31 -> sdk60 #17671

Regression in nuget restore for sfproj from sdk31 -> sdk60 #17671

Comments

ghost commented May 17, 2021 • edited by ghost Loading

Minimal repro

expected

actual

versions

dotnet-issue-labeler bot commented May 17, 2021

rainersigwald commented May 17, 2021 • edited Loading

ghost commented May 17, 2021 • edited by ghost Loading

rainersigwald commented May 17, 2021

nkolev92 commented May 17, 2021

nkolev92 commented May 17, 2021

ghost commented May 17, 2021

nkolev92 commented May 17, 2021

ghost commented May 17, 2021

nkolev92 commented May 17, 2021

ghost commented May 17, 2021 • edited by ghost Loading

nkolev92 commented May 18, 2021

ghost commented May 17, 2021 •

edited by ghost

Loading

rainersigwald commented May 17, 2021 •

edited

Loading

ghost commented May 17, 2021 •

edited by ghost

Loading

ghost commented May 17, 2021 •

edited by ghost

Loading