Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Megathread] Engineering Status of RID Improvements and Publish UX Changes #26503

Closed
14 of 16 tasks
nagilson opened this issue Jul 11, 2022 · 2 comments
Closed
14 of 16 tasks
Assignees
Labels
Area-NetSDK untriaged Request triage from a team member

Comments

@nagilson
Copy link
Member

nagilson commented Jul 11, 2022

This is to help me keep organized on what I still need to implement for the issues specified here by @richlander and resolves #26446 and so others can see the progress on those issues. I will be closing them out as well, but this may be helpful.

PR 1) #26143

  • 0) Use implicit RID in the following situations:

    • For any publish property that requires a rid, use the default RID, just like if --use-current-runtime is specified.
      That means:
      • SelfContained
      • PublishAot
      • PublishReadyToRun
      • PublishSingleFile
      • PublishTrimmed
      • PublishSelfContained
  • 1) Add PublishSelfContained property.

    • Set self contained to true automatically when we're publishing
    • Make sure it takes precedence over self-contained=false

Remaining:

  • Make sure this doesn't break rid agnostic projects.

PR 2) _____

  • 0) Add RuntimeSpecific property.
    -> Sets self contained to false
    -> Uses the implicit RID (portable one)

    Verify:

    • Make sure you can still specify -r runtime without it being overriden.
    • Make sure you can still specify self-contained to true even if you do /p:SelfContained=true.

PR 3) ______

  • 0) Add --ucr shorthand for use-current-runtime.

PR 4) ______

  • Add PublishRuntimeIdentifier property.
@richlander
Copy link
Member

Looks good!

I'd say that the --ucr request is lowest on the list.

@nagilson
Copy link
Member Author

nagilson commented Nov 7, 2022

All of these are done except RuntimeSpecific, which is here #28412 and waiting for 8.0 SDK Build changes. Going to close this!

@nagilson nagilson closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

2 participants