[GenAPI] setup the Simplifier to produce fully qualified type names.

[andriipatsula]

sdk/src/GenAPI/Microsoft.DotNet.GenAPI/CSharpFileBuilder.cs

Line 83 in 9ffab85

document = Simplifier.ReduceAsync(document).Result;

The Simplifier by default "simplify" namespaces and type names. We'd like the GenAPI to produce fully qualified type names.

[ericstj]

One way to do this might be to remove the Simplifier.Annotation from specific SyntaxNodes using SyntaxNode.WithoutAnnotations. We'd want to be careful to not do that everywhere since it would prevent simplification to keyword of things like int, double, etc.

I wonder how much we really care about the full names? I suspect we used fullnames everywhere before because GenAPI was trying to be conservative and ensure that it produced code that would compile. Roslyn is smarter and so long as it produces correct source, it might be a feature that it's more succinct.

@andriipatsula @ViktorHofer do you know why we wanted full names here? Was it just to create a smaller diff?

[ViktorHofer]

@andriipatsula @ViktorHofer do you know why we wanted full names here? Was it just to create a smaller diff?

From my point of view - yes. As an example the changes in https://github.com/dotnet/source-build-reference-packages/pull/633/files#diff-69cc363eb68a334a9f6cccbcbda21ba0f7f9cd3205e60e17657c63856ae78806 aren't reviewable because of the large diff.

[andriipatsula]

From the Source-Build perspective - it does not matter where we produce fully qualified names or not.

[ViktorHofer]

Not necessary for 8.0. Moving into the backlog.