Add support for --disable-build-servers to more MSBuild-driven commands

[baronfel]

Is your feature request related to a problem? Please describe.

In .NET 7 we added the --disable-build-servers option to build, restore, and publish to make it easier for developers to have complete control over the use of build servers of all kinds in their builds. Some commands that are still driven by MSBuild are missing in that set, so we should add support to ensure that there is a consistent set of behaviors across all MSBuild-driven commands.

Describe the solution you'd like

We should add the --disable-build-servers option to the following commands:

• clean
• test
• run
• pack
• msbuild

[KalleOlaviNiemitalo]

Can dotnet list package start MSBuild servers?

[MiYanni]

Research

Just FYI, here are the current commands using this feature:

This means, out of the original list for the issue, only run doesn't have the option.

Here are the commands that implement MSBuildForwardingApp. Meaning, these commands invoke MSBuild:

FYI, RestoringCommand is a base for these commands that do a restore operation:

Notes

• dotnet list package uses and instance of NuGetForwardingApp. So, that doesn't use MSBuild and should not have this option.
• dotnet run creates an instance of RestoringCommand to ensure the project is built. Therefore, it should have this option.

[KalleOlaviNiemitalo]

OK, I see dotnet list package requires a NuGet assets file and fails if NuGet packages have not been restored, so I presume it doesn't query MSBuild for PackageReference items.

How about dotnet list reference though? That doesn't need an assets file. Does it call any MSBuild targets in order to find the ProjectReference items; can it start build servers?

[MiYanni]

Looks like dotnet list reference uses the MSBuild SDK to get the list of project-to-project references. It doesn't run MSBuild either.

Based on what I've investigated, I'm adding the option to both run and store. Going to make some unit tests right now for it.