Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postcompile/precompile doesn't respect exit code of the command #4538

Closed
krwq opened this issue Dec 9, 2015 · 3 comments
Closed

postcompile/precompile doesn't respect exit code of the command #4538

krwq opened this issue Dec 9, 2015 · 3 comments
Labels
Bug
Milestone
Backlog

Comments

@krwq
Copy link
Member

krwq commented Dec 9, 2015

compile doesn't fail when the postcompile/pre command failed.
@TheRealPiotrP
Copy link
Contributor

We expect to be dropping script support, so putting this off for now.

@analogrelay
Copy link
Contributor

Are we still dropping script support? /cc @piotrpMSFT @davidfowl

If not, this is affecting our own builds because we do a dotnet build in a precompile script (for ArgumentForwarderTests) and if it fails, the build doesn't fail.

@TheRealPiotrP
Copy link
Contributor

The team is actively working on enabling MSBuild and the component affected will be superseded by the new project system, so I am closing this issue.

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the Backlog milestone Jan 31, 2020
@cdmihai cdmihai mentioned this issue Jan 31, 2020
Closed
rainersigwald pushed a commit that referenced this issue Jul 20, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/fsharp build 20200…
4846e13 
…504.4 (#4538)

- Microsoft.FSharp.Compiler: 10.10.0-beta.20230.7 -> 10.10.0-beta.20254.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@analogrelay @krwq @TheRealPiotrP @msftgits