Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PublishRuntimeIdentifier #28717

Merged
merged 21 commits into from
Nov 4, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ public TestProject([CallerMemberName] string name = null)
}
}

/// <summary>
/// A custom nametag for the project that's appended to a root test folder. By default, it is the unhashed name of the function that instantiated the TestProject object.
/// </summary>
public string Name { get; set; }

public bool IsSdkProject { get; set; } = true;
Expand Down
3 changes: 3 additions & 0 deletions src/Tests/Microsoft.NET.TestFramework/TestAsset.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ public class TestAsset : TestDirectory

public string TestRoot => Path;

/// <summary>
/// The hashed test name (so file paths do not become too long) of a particular test. This will be the root of the test folder.
nagilson marked this conversation as resolved.
Show resolved Hide resolved
/// </summary>
public readonly string Name;

public ITestOutputHelper Log { get; }
Expand Down
9 changes: 9 additions & 0 deletions src/Tests/Microsoft.NET.TestFramework/TestAssetsManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@ public TestAsset CopyTestAsset(
return testAsset;
}

/// <summary>
///
/// </summary>
/// <param name="testProject">The testProject used to create a teatAsset with.</param>
/// <param name="callingMethod">Defaults to the name of the caller function (presumably the test). Used to prevent file collisions on tests which share the same test project.</param>
/// <param name="identifier">An ID for the project that should be unique for every test, including each theory child test.
nagilson marked this conversation as resolved.
Show resolved Hide resolved
/// This is distinct from the test project name and is used to prevent file collisions between theory tests that use the same test project.</param>
/// <param name="targetExtension">The extension type of the desired test project, e.g. .csproj, or .fsproj.</param>
/// <returns></returns>
public TestAsset CreateTestProject(
TestProject testProject,
[CallerMemberName] string callingMethod = "",
Expand Down