Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0.1xx] installer fails to build using a sdk+packages built by installer #3030

Closed
tmds opened this issue Sep 20, 2022 · 3 comments
Closed
Assignees

Comments

@tmds
Copy link
Member

tmds commented Sep 20, 2022

If you build installer using an SDK and packages from a previous installer build, the build fails.

runtime repo's crossgen2.csproj project fails to resolve the RuntimeIdentifier.
I've patched it in dotnet/installer#14549 using:

-    <RuntimeIdentifiers Condition="'$(DotNetBuildFromSource)' == 'true'">$(PackageRID)</RuntimeIdentifiers>
+    <RuntimeIdentifier Condition="'$(DotNetBuildFromSource)' == 'true'">$(PackageRID)</RuntimeIdentifier>
+    <AppendRuntimeIdentifierToOutputPath Condition="'$(RunningPublish)' != 'true'">false</AppendRuntimeIdentifierToOutputPath>

The fsharp repo fails with:

    FSharp.Build -> /home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/artifacts/bin/FSharp.Build/Proto/netstandard2.0/FSharp.Build.dll
    FSharp.Compiler.Service -> /home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/artifacts/bin/FSharp.Compiler.Service/Proto/netstandard2.0/FSharp.Compiler.Service.dll
FSC : error : no entrypoint specified in executable binary [/home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/src/fsc/fscProject/fsc.fsproj::TargetFramework=net7.0] [/home/tmds/tarball61/Tools/source-built/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj]
##vso[task.logissue type=error;sourcepath=FSC;linenumber=0;columnnumber=0;code=;]no entrypoint specified in executable binary [/home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/src/fsc/fscProject/fsc.fsproj::TargetFramework=net7.0%5D
    fsc -> /home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/artifacts/bin/fsc/Proto/net7.0/fsc.dll
FSC : error : no entrypoint specified in executable binary [/home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/src/fsi/fsiProject/fsi.fsproj::TargetFramework=net7.0] [/home/tmds/tarball61/Tools/source-built/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj]
##vso[task.logissue type=error;sourcepath=FSC;linenumber=0;columnnumber=0;code=;]no entrypoint specified in executable binary [/home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/src/fsi/fsiProject/fsi.fsproj::TargetFramework=net7.0%5D
    fsi -> /home/tmds/tarball61/src/fsharp/artifacts/source-build/self/src/artifacts/bin/fsi/Proto/net7.0/fsi.dll
@tmds
Copy link
Member Author

tmds commented Sep 20, 2022

cc @crummel @MichaelSimons

@MichaelSimons
Copy link
Member

The crossgen2 issue is tracked with dotnet/sdk#27985 and already has a fix. @crummel has been investigating the FSharp issue.

@MichaelSimons MichaelSimons transferred this issue from dotnet/installer Sep 20, 2022
@MichaelSimons MichaelSimons moved this from 7.0 RC2 to WIP in .NET Source Build Sep 21, 2022
@MichaelSimons
Copy link
Member

This was fixed with dotnet/fsharp#13963 and fsharp also checked in a fix for it which has already flown into 7.0 with dotnet/installer#14608

Repository owner moved this from WIP to Done in .NET Source Build Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants