Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SBRP] add System.Drawing.Common 7.0.0 ref pack #3338

Closed
MichaelSimons opened this issue Mar 20, 2023 · 1 comment
Closed

[SBRP] add System.Drawing.Common 7.0.0 ref pack #3338

MichaelSimons opened this issue Mar 20, 2023 · 1 comment
Labels
area-sbrp Source build reference packages

Comments

@MichaelSimons
Copy link
Member

This is needed as a result of dotnet/runtime#83356. This is needed because there are System.Drawing.Common references within the runtime repo that are no longer satisfied by the live version which was removed.

In order to add this SBRP, the net 7.0 targeting pack will need to be created first. We don't want to add this right now as it might break the build. The reason I say might is because there are a number of repos that still target net7.0 and haven't upgraded to net8.0. If any of these repos utilize generators/analyzers from the net7.0 targeting pack, they would break because the SBRP version will not contain the generators/analyzers.
@MichaelSimons MichaelSimons moved this to 8.0 Backlog in .NET Source Build Mar 20, 2023
@ViktorHofer ViktorHofer added the area-sbrp Source build reference packages label Mar 28, 2023
@MichaelSimons MichaelSimons moved this from 8.0 Backlog to 8.0 Preview 5 in .NET Source Build Apr 4, 2023
@MichaelSimons
Copy link
Member Author

This was added with dotnet/source-build-reference-packages#609

@github-project-automation github-project-automation bot moved this from 8.0 Preview 5 to Done in .NET Source Build Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-sbrp Source build reference packages
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ViktorHofer @MichaelSimons