Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider running prebuilt detection on failing builds #4103

Open
ViktorHofer opened this issue Feb 8, 2024 · 1 comment
Open

Consider running prebuilt detection on failing builds #4103

ViktorHofer opened this issue Feb 8, 2024 · 1 comment
Labels
area-arcade Common Arcade source-build infra

Comments

@ViktorHofer
Copy link
Member

In the case of dotnet/runtime#98006 prebuilt detection didn't run because the build failed. What's interesting about this PR is that it failed because it used the actual packages and not the SBRP ones for Microsoft.Build.Tasks.Core/17.8.3 and Microsoft.Build.Tasks.Core/17.8.3 but SBRPs for Microsoft.Build/17.8.3 and its dependencies.

The mix of SBRP and real packages for MSBuild wasn't obvious from the failing source-build leg. It failed with a very cryptic error which I wasn't able to diagnose. Kudos to @ericstj who found the actual problem.

As the source-build leg didn't log prebuilt errors, I didn't consider that SBRPs are still missing. I wonder if it would make sense to always run prebuilt detection, even when a build fails. Alternatively, should prebuilt detection run after restore instead of after the entire build?

@MichaelSimons
Copy link
Member

Alternatively, should prebuilt detection run after restore instead of after the entire build?

Generally speaking restore is not the only way prebuilts are introduced. Installer in particular has many ways in which assets are pulled in outside of retore that get flagged by prebuilt detection.

@MichaelSimons MichaelSimons added area-arcade Common Arcade source-build infra and removed untriaged area-prebuilt-reduction labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-arcade Common Arcade source-build infra
Projects
Status: Backlog
Development

No branches or pull requests

2 participants