Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument name suggestions in methods/ctors #1254

Closed
jchannon opened this issue Feb 20, 2017 · 7 comments
Closed

Argument name suggestions in methods/ctors #1254

jchannon opened this issue Feb 20, 2017 · 7 comments

Comments

@jchannon
Copy link
Contributor

Environment data

dotnet --info output:

.NET Command Line Tools (1.0.0-rc4-004771)

Product Information:
 Version:            1.0.0-rc4-004771
 Commit SHA-1 hash:  4228198f0e

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.11
 OS Platform: Darwin
 RID:         osx.10.11-x64
 Base Path:   /usr/local/share/dotnet/sdk/1.0.0-rc4-004771

VS Code version:1.9
C# Extension version:1.8 beta

Steps to reproduce

Enter a type into a constructor then begin to type the name of the argument

Expected behavior

Suggestions of what to call it in a drop down eg. if you have public Foo(Bar it should give suggest bar

Actual behavior

N/A

@DustinCampbell
Copy link
Member

I'm confused by the title, which talks about field names, but the expected behavior seems to describe the completion list suggesting parameter names. Is your request essentially dotnet/roslyn#7055?

@jchannon
Copy link
Contributor Author

My bad.

Yup that roslyn feature 😄

@jchannon jchannon changed the title Field suggestions in methods/ctors Argument name suggestions in methods/ctors Feb 20, 2017
@DustinCampbell
Copy link
Member

Thanks for clarifying. I wouldn't spend the effect adding this to VS Code since we don't want the C# editing experience to diverge. But once we get it in Roslyn, we'll definitely bring it here.

cc @Pilchie

@jchannon
Copy link
Contributor Author

jchannon commented May 2, 2017

Looks like it's in. What needs to be done to bring it in?

@DustinCampbell
Copy link
Member

It's just a matter of time now. We've got some changes coming that should allow this feature to show up in VS Code.

@jchannon
Copy link
Contributor Author

jchannon commented May 4, 2017

Does it come automatically or does something else need doing, do you need some help?

@DustinCampbell
Copy link
Member

We'll always take help! 😄 That said, this should come in naturally when we update OmniSharp to the latest Roslyn packages. AFAIK, these changes aren't available on NuGet yet, and I'd prefer that over grabbing random nightlies from the Roslyn MyGet feed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants