Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put WindowsDesktop shared framework bundle installer through loc process #921

Closed
dagood opened this issue Jul 31, 2019 · 3 comments
Closed

Put WindowsDesktop shared framework bundle installer through loc process #921

dagood opened this issue Jul 31, 2019 · 3 comments

Comments

@dagood
Copy link
Member

dagood commented Jul 31, 2019

There are new strings with the WindowsDesktop shared framework bundle installer (at minimum .NET Core Runtime => Windows Desktop Runtime) that need to be localized.

Currently blocked on getting the branding info to localize: https://github.com/dotnet/core-setup/issues/7530.
@dagood dagood self-assigned this Jul 31, 2019
@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@NikolaMilosavljevic NikolaMilosavljevic transferred this issue from dotnet/runtime Jun 30, 2020
@dagood dagood removed their assignment Jul 1, 2020
@RussKie
Copy link
Member

RussKie commented Mar 31, 2021

@dagood is this still a thing?

@dagood
Copy link
Member Author

dagood commented Mar 31, 2021

This is a preemptively filed followup issue to #191.

/cc @NikolaMilosavljevic

@RussKie
Copy link
Member

RussKie commented Mar 31, 2021

#191 was resolved by #769, which introduced loc'ed strings.
Presume fixed.

@RussKie RussKie closed this as completed Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RussKie @dagood