From 2c32c888072a0606b5c6250ce6c1543e2bde9cef Mon Sep 17 00:00:00 2001 From: Eugene Rozenfeld Date: Fri, 14 Aug 2020 19:33:05 -0700 Subject: [PATCH] Fix TailCallStress mode. (dotnet/runtime#40698) Improve validation of tail calls that are not tail-prefixed in the IL but are marked as such because of TailCallStress. We now do the same correctness validation in morph for such tail calls as we do for implicit tail calls. That blocks tail calls when we have address-taken locals, struct promoted params, and pinned vars. Fixes dotnet/runtime#39398. Fixes dotnet/runtime#39309. Fixes dotnet/runtime#38892. Fixes dotnet/runtime#38889. Fixes dotnet/runtime#38887. Fixes dotnet/runtime#37117. Fixes dotnet/runtime#8017. Commit migrated from https://github.com/dotnet/runtime/commit/7742b574c02f4e68493aff217fd1c3a957c4ae46 --- src/System.Drawing.Common/tests/FontTests.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/System.Drawing.Common/tests/FontTests.cs b/src/System.Drawing.Common/tests/FontTests.cs index 067ff89a7be..f731cdb9dda 100644 --- a/src/System.Drawing.Common/tests/FontTests.cs +++ b/src/System.Drawing.Common/tests/FontTests.cs @@ -784,7 +784,6 @@ public void SizeInPoints_Get_ReturnsExpected(GraphicsUnit unit) [InlineData(FontStyle.Strikeout | FontStyle.Bold | FontStyle.Italic, 255, true, "@", 700)] [InlineData(FontStyle.Regular, 0, false, "", 400)] [InlineData(FontStyle.Regular, 10, false, "", 400)] - [SkipOnCoreClr("https://github.com/dotnet/runtime/issues/38889", RuntimeTestModes.TailcallStress)] public void ToLogFont_Invoke_ReturnsExpected(FontStyle fontStyle, byte gdiCharSet, bool gdiVerticalFont, string expectedNamePrefix, int expectedWeight) { using (FontFamily family = FontFamily.GenericMonospace) @@ -818,7 +817,6 @@ public void ToLogFont_Invoke_ReturnsExpected(FontStyle fontStyle, byte gdiCharSe [InlineData(TextRenderingHint.SingleBitPerPixel)] [InlineData(TextRenderingHint.SingleBitPerPixelGridFit)] [InlineData(TextRenderingHint.ClearTypeGridFit)] - [SkipOnCoreClr("https://github.com/dotnet/runtime/issues/38889", RuntimeTestModes.TailcallStress)] public void ToLogFont_InvokeGraphics_ReturnsExpected(TextRenderingHint textRenderingHint) { using (FontFamily family = FontFamily.GenericMonospace)