Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create android adb command #726

Closed
premun opened this issue Sep 30, 2021 · 0 comments · Fixed by #782
Closed

Create android adb command #726

premun opened this issue Sep 30, 2021 · 0 comments · Fixed by #782
Assignees
Labels
android Android area enhancement New feature or request

Comments

@premun
Copy link
Member

premun commented Sep 30, 2021

Context

Sometimes we want to use the bundled ADB directly. Currently, we can call android state --adb to get path to the ADB executable and then run that.

Follow up of #724

Goals

  • Add the android adb command which would just forward the arguments to adb and pipe the output/exit code.
  • The command should accept XHarness arguments still (like -v or -h) and only forward the PassThroughArguments which are deliminated by -- so for example:
    xharness android adb -v -- devices list
    
  • We should make sure we run ADB in the same way we run programs in Apple, so with a ProcessManager
  • We need to make sure we pipe the output well and not buffer it in memory to prevent common CLI issues
  • Once this is finished, we should remove the --adb options from the android state command (revert that whole change)
@premun premun added android Android area enhancement New feature or request labels Oct 1, 2021
@premun premun self-assigned this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android area enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant