Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render the search input inside the dropdown. not on the toggle button #308

Closed
ingmothman opened this issue Nov 21, 2019 · 5 comments · Fixed by #309
Closed

render the search input inside the dropdown. not on the toggle button #308

ingmothman opened this issue Nov 21, 2019 · 5 comments · Fixed by #309

Comments

@ingmothman
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I need to render the search box inside the dropdown, not on the main button.

Describe the solution you'd like
a configuration option allows us to choose where to render the search button

Describe alternatives you've considered
Fork the repo!.

Additional context
This is the design i am trying to achieve.
image

@mrchief
Copy link
Collaborator

mrchief commented Nov 21, 2019

That seems like a useful thing to have. Would you like to send me a PR?

@mrchief
Copy link
Collaborator

mrchief commented Nov 23, 2019

Based on the screenshot, it seems like the design goals are:

  • inline search input (inline with content)
  • simple select, no tree
  • no tags either?
  • dropdown title needed next to the toggle button (YTD... ^ in the screenshot)

Am I missing anything?

@ingmothman
Copy link
Contributor Author

No, i only need to render the search input inside the dropdown-content. everything else can be solved by styling on my side. thanks.

@stale
Copy link

stale bot commented Dec 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 9, 2019
@mrchief mrchief added enhancement wip Work In Progress and removed stale labels Dec 9, 2019
@mrchief
Copy link
Collaborator

mrchief commented Jan 18, 2020

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mrchief mrchief added released and removed wip Work In Progress labels Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants