You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Within forked repositories it is possible to run TravisCI runs, but there is always a coveralls failure.
Please disable coveralls invocation when CI runs on forks.
As an idea:
run all JS tests on branches and pull-requests
only run coveralls on pull-requests (which will always be on this repository)
The text was updated successfully, but these errors were encountered:
only run coveralls on pull-requests (which will always be on this repository)
this is the thing though - unless the branch exists on this repo, the PR's branch will be on a personal fork and sharing secrets to external forks is a not a good idea since you expose yourself to potential theft of secrets. This is why GH actions don't do it. Travis + Coveralls works differently in that the code is forked to their servers and tests are run there and results are reported back.
I feel like something got broken when I was trying to get rid of Travis and then had to re-enable it because I wanted coveralls. So I have a feeling that just revisiting tokens and making sure we have the proper ones added, will fix this issue.
That said, now I'm wondering - did it ever work? If not, then I might be trying to solve an impossible to solve issue. :)
Github has introduced pull_request_target event which can help towards this. I've been swamped at work lately so I'll try it our when I have some time or if you wanna try it and send a PR, please feel free to do so,
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.
Describe the bug
Within forked repositories it is possible to run TravisCI runs, but there is always a
coveralls
failure.Please disable coveralls invocation when CI runs on forks.
As an idea:
The text was updated successfully, but these errors were encountered: