Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable coveralls invocation on forked repositories #397

Closed
mobilutz opened this issue Jul 14, 2020 · 3 comments
Closed

Disable coveralls invocation on forked repositories #397

mobilutz opened this issue Jul 14, 2020 · 3 comments

Comments

@mobilutz
Copy link
Contributor

Describe the bug
Within forked repositories it is possible to run TravisCI runs, but there is always a coveralls failure.
Please disable coveralls invocation when CI runs on forks.

As an idea:

  • run all JS tests on branches and pull-requests
  • only run coveralls on pull-requests (which will always be on this repository)
@mrchief
Copy link
Collaborator

mrchief commented Jul 14, 2020

only run coveralls on pull-requests (which will always be on this repository)

this is the thing though - unless the branch exists on this repo, the PR's branch will be on a personal fork and sharing secrets to external forks is a not a good idea since you expose yourself to potential theft of secrets. This is why GH actions don't do it. Travis + Coveralls works differently in that the code is forked to their servers and tests are run there and results are reported back.

I feel like something got broken when I was trying to get rid of Travis and then had to re-enable it because I wanted coveralls. So I have a feeling that just revisiting tokens and making sure we have the proper ones added, will fix this issue.

That said, now I'm wondering - did it ever work? If not, then I might be trying to solve an impossible to solve issue. :)

@mrchief
Copy link
Collaborator

mrchief commented Oct 3, 2020

Github has introduced pull_request_target event which can help towards this. I've been swamped at work lately so I'll try it our when I have some time or if you wanna try it and send a PR, please feel free to do so,

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants