Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): Adding react 17 to peer dependencies #487

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

paycorchauhan
Copy link
Contributor

@paycorchauhan paycorchauhan commented May 11, 2021

With NPM 7 peer dependencies are automatically installed unlike previous versions. Since React 17
was not defined as a peer dependency hence the install of package failed on projects using Npm7 + React
17.

React 17 support #486

What does it do?

This fixes the install error that occurred when working with NPM 7 and React 17 by adding react 17 to peer dependencies.
Before
image
After
image

Fixes # (issue)

Fixes #486

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Updated documentation (if applicable)
  • Added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

With NPM 7 peer dependencies are automatically installed unlike previous versions. Since React 17
was not defined as a peer dependency the install of package failed on projects using Npm7 + React
17.

React 17 support dowjones#486
@codeclimate
Copy link

codeclimate bot commented May 11, 2021

Code Climate has analyzed commit 9fe9df1 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1535

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.901%

Totals Coverage Status
Change from base Build 1526: 0.0%
Covered Lines: 598
Relevant Lines: 619

💛 - Coveralls

@mrchief mrchief merged commit d22f809 into dowjones:develop Jun 14, 2021
@github-actions
Copy link

github-actions bot commented Mar 6, 2022

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 17 support
3 participants