Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Minimum react 18 support #607

Merged
merged 1 commit into from
Jan 15, 2023
Merged

feat: Minimum react 18 support #607

merged 1 commit into from
Jan 15, 2023

Conversation

pckilgore
Copy link
Contributor

@pckilgore pckilgore commented Dec 7, 2022 •
edited
Loading

What does it do?

Adds support for React 18, which ends support for certain lifecycle methods not prefixed by unsafe_.

See: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

For additional context

Fixes #560

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Updated documentation (if applicable)
  • Added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@pckilgore pckilgore changed the title Main feat: Minimum react 18 support Dec 7, 2022
@pckilgore
Copy link
Contributor Author

Thanks codespaces, otherwise I doubt I would have bothered....

@pckilgore
Copy link
Contributor Author

I don't think I can debug the Netlify failures, but let me know if there's anything else I can do.

mrchief
mrchief approved these changes Jan 15, 2023
View reviewed changes
Copy link
Collaborator

@mrchief mrchief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this!

@mrchief mrchief merged commit 58dec44 into dowjones:main Jan 15, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ChaitraNarayanaSwamy
Copy link

Feature is not working as expected with React 18, child nodes and dropdown arrow are not displayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrchief mrchief mrchief approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: React 18 support?
3 participants
@pckilgore @ChaitraNarayanaSwamy @mrchief