Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Map is always detected as available in iOS #116

Closed
svenkeeter opened this issue Mar 3, 2017 · 4 comments
Closed

Apple Map is always detected as available in iOS #116

svenkeeter opened this issue Mar 3, 2017 · 4 comments
Labels

Comments

@svenkeeter
Copy link

svenkeeter commented Mar 3, 2017

Even when Apple Maps is uninstalled, running:

launchnavigator.availableApps(function(results){
    for(var app in results){
        console.log(launchnavigator.getAppDisplayName(app) + (results[app] ? " is" : " isn't") +" available");
    }
});

will always return it as available in iOS

@dpa99c
Copy link
Owner

dpa99c commented Mar 3, 2017

Before iOS 10, you couldn't delete built-in apps, so the plugin just assumes it's there.

So it needs updating to check for presence of Apple Maps, just like for any other app.

@dpa99c dpa99c added the bug label Mar 3, 2017
@svenkeeter
Copy link
Author

Thank you for your prompt reply. I'll see what i can do about it or just wait for the fix 😃

@dpa99c
Copy link
Owner

dpa99c commented Mar 31, 2017

It doesn't look like it's possible to detect if Apple Maps is installed or not, since removing it does not actually uninstall the app, it just hides the icon from the home screen.

I'm going by this SO question.

So it seems not possible to detect if Apple Maps is unavailable in advance (which is the exact intention of launchnavigator.availableApps().

The best that can be done is to gracefully handle the error when attempting to open Apple Maps using launchnavigator.navigate().

So I think this issue needs to be documented as a caveat rather than fixed as a bug.

@dpa99c dpa99c added todo and removed bug labels Mar 31, 2017
@dpa99c dpa99c closed this as completed in 8eba684 Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants