Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build task instead of commands #9

Open
ErikBehar opened this issue Sep 13, 2018 · 2 comments
Open

Make build task instead of commands #9

ErikBehar opened this issue Sep 13, 2018 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@ErikBehar
Copy link

It would be best if we could generate a build task in the normal flow of vscode instead of a build command.
This allows you to add flags and configure the actual command to your liking.

@dprogm
Copy link
Owner

dprogm commented Sep 14, 2018

I already thought about that idea too. Maybe we can use both in parallel? It would also avoid to query targets all the time you want to build one specific target. Maybe we can introduce a new command like 'configure build tasks'.

@dprogm dprogm added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Sep 19, 2018
@quentingodeau
Copy link
Contributor

Hi everyone!

I also thinks that a good idea. In my mind I was more thinking to implement the auto task detection, like for npm. I try to do so and finally manage to a result (I follow this sample). Also to avoid query each time bazel I do like them, and cache the result, note that it become invalid if a bazel file is modified.

@ErikBehar For the configuration part that you mention, my current solution do not solve it, because I do not get the Tasks definitions when I have to create them... It a little be strange but I think that direcly link to this issue. I may write a workaround in the futur (but hope that Microsoft solve the issue quickly)

How to test the version:

git clone https://github.com/quentingodeau/vscode-bazel-tools.git
cd vscode-bazel-tools
git checkout feature/task-provider

npm install
npm run compile

Then open vscode and open the  vscode-bazel-tools folder
Finally press F5

@dprogm @ErikBehar Please let me know what you think of it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants