fix(sysdig): set filter being compatible with chisel api #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
therealbobo
force-pushed
the
fix-set-filter-chisel-api
branch
from
c969e13
to
70baa9c
Compare
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
therealbobo
force-pushed
the
fix-set-filter-chisel-api
branch
from
70baa9c
to
f3bf1c2
Compare
mrgian
approved these changes
Jul 18, 2024
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
…elease Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
therealbobo
force-pushed
the
fix-set-filter-chisel-api
branch
from
78ed533
to
3290b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter string in needed by some chisels. Given that the filter is already automatically compiled within libsinsp, using the filter string instead of the compiled filter will correctly set the filter string in sinsp.