Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORSService to support CORS #546

Closed
crookse opened this issue Oct 24, 2021 · 6 comments
Closed

Add CORSService to support CORS #546

crookse opened this issue Oct 24, 2021 · 6 comments
Assignees

Comments

@crookse
Copy link
Member

crookse commented Oct 24, 2021

Check the logic against expressjs/cors

@ebebbington
Copy link
Member

it fails in browsers and via fetch because the origin header isn't set, hence why it passes in the ci

@ebebbington
Copy link
Member

(after investigating)

@ebebbington
Copy link
Member

Try going to deno.land and make a fetch req in the console to your server?

@ebebbington
Copy link
Member

image
(My server set cors origin to google.com, i made these requests from the dev console on https://deno.land)

@crookse crookse changed the title Is CORSService working as expected? Add CORSService to support CORS Nov 13, 2021
@crookse
Copy link
Member Author

crookse commented Mar 20, 2022

ok.. i just tested this locally and it works as expected.. idk why i ran into issues earlier... dafuq. imma write the docs for this

@crookse
Copy link
Member Author

crookse commented Oct 10, 2023

closing because of staleness. will come back to it later if needed

@crookse crookse closed this as completed Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants