Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SessionService #558

Open
3 tasks
ebebbington opened this issue Jun 8, 2020 · 4 comments
Open
3 tasks

Add SessionService #558

ebebbington opened this issue Jun 8, 2020 · 4 comments

Comments

@ebebbington
Copy link
Member

Develop session middleware, using http://expressjs.com/en/resources/middleware/cookie-session.html as inspiration

Acceptance Criteria

  • Develop middleware -- taking cookie-session as inspiration.
  • Write unit tests
  • A VERY DETAILED README (see other middleware READMEs as examples)

Taking on this issue? Read this before you get started.

If you take on this issue and the acceptance criteria does not make sense, post comments on this issue with your questions. Also, you can always hop in the Discord channel at https://discord.gg/c5R3sYuR to get help quickly.

Please read the Contributing Guidelines before starting this issue.
@crookse
Copy link
Member

crookse commented Jun 8, 2020

@DevYusuf, just tagging you here so you can follow

@ebebbington
Copy link
Member Author

Updated the description. I guess users can always use this middleware with their database/redis

@ebebbington
Copy link
Member Author

maybe we can work things like laravels loginAs and Auth::user() into this? would require all db drivers as ependencies though - or maybe even a separate middleware

@crookse crookse changed the title Add Session Middleware feat: Session middleware Oct 31, 2020
@crookse crookse changed the title feat: Session middleware Session middleware Nov 1, 2020
@crookse
Copy link
Member

crookse commented Nov 4, 2020

i havent made any progress on this. putting it back in to do

@crookse crookse removed their assignment Nov 4, 2020
@ebebbington ebebbington transferred this issue from drashland/deno-drash-middleware Nov 2, 2021
@crookse crookse changed the title Session middleware SessionService Nov 26, 2021
@crookse crookse changed the title SessionService Add SessionService Nov 26, 2021
@crookse crookse mentioned this issue Dec 16, 2021
Closed
@Guergeiro Guergeiro mentioned this issue Apr 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crookse @ebebbington