From 88d4fa61951830ebce38e11421d5d5cdda06a7f8 Mon Sep 17 00:00:00 2001 From: Glenn Rice Date: Sat, 7 Dec 2024 19:18:02 -0600 Subject: [PATCH] Fix a typo in the `data_feedback_insert_element` attribute and use a div instead of a span. This is not particularly consequential since the feedback button is still inserted after the select. That is the same as what the data attributes end up doing. However, using a `span` is a problem, becuase the feedback popover is inserted into the span which results in invalid HTML. So a display inline `div` is used instead. --- macros/parsers/parserPopUp.pl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/macros/parsers/parserPopUp.pl b/macros/parsers/parserPopUp.pl index da094036c..357555fd5 100644 --- a/macros/parsers/parserPopUp.pl +++ b/macros/parsers/parserPopUp.pl @@ -389,10 +389,10 @@ sub MENU { if ($main::displayMode =~ m/^HTML/) { $menu = main::tag( - 'span', - class => 'text-nowrap', - data_feedback_insert_elt => $name, - data_feedback_insert_method => 'append_content', + 'div', + class => 'd-inline text-nowrap', + data_feedback_insert_element => $name, + data_feedback_insert_method => 'append_content', main::tag( 'select', class => 'pg-select',