Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use String() instead of fmt.Sprintf #174

Closed
wants to merge 1 commit into from
Closed

chore: use String() instead of fmt.Sprintf #174

wants to merge 1 commit into from

Conversation

testwill
Copy link

No description provided.

@gouguoyin
Copy link
Collaborator

What is the difference?

@testwill
Copy link
Author

should use String() instead of fmt.Sprintf (megacheck)
you can use obj.String() instead of fmt.Sprintf("%s", obj) because fmt.Sprintf calls obj.String() internally

@gouguoyin
Copy link
Collaborator

Intentionally using fmt.Sprintf() to test the scenario of forcing the c.Lunar() struct to be output as string

@gouguoyin gouguoyin closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@testwill @gouguoyin