Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks don't open #2

Closed
remib opened this issue Aug 5, 2015 · 3 comments
Closed

Hyperlinks don't open #2

remib opened this issue Aug 5, 2015 · 3 comments

Comments

@remib
Copy link

remib commented Aug 5, 2015

Great solution but I notice you don't actually create a working hyperlink in your filter.

I've managed to implement hyperlinks using href but seeing as this is for ionic it needs to open using the inappbrowser plugin, otherwise the link opens in the same webview as the app and there's no way to return to the app without closing it and reopening it. I've tried implementing this via the suggested window.open method in the plugin docs but the ng-click gets removed at some stage, presumably because of unsafe html and/or scopes but I cannot figure out a solution.

Any ideas how to get clickable links within tweets that open in inappbrowser?

Many thanks.

@drrasic
Copy link
Owner

drrasic commented Aug 5, 2015

Yeah i had the same problem, if i remember corectly that kind of stuff doesnt work because ofthe linking processes in angular Compiler, so i think that can be done with a directive so you can go that route, ill probably try to do that when i snatch some spare time to improve this plugin..

**for my client i just opened whole tweet in innap browser when user "ng-clicked" anywhere on the post. and it was ok with him ;)

@remib
Copy link
Author

remib commented Aug 5, 2015

That might actually suffice for now, thanks for getting back to me.

Edit: I did come across this which might help http://plnkr.co/edit/vUWro6?p=preview it compiles the tweet correctly but I haven't quite got my head around it yet!

@drrasic
Copy link
Owner

drrasic commented Aug 10, 2015

Yeah thats it, i have updated plugin with that solution.

@drrasic drrasic closed this as completed Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants