Skip to content

Commit

Permalink
fix: agrega tipos a constants y crea lista de tareas todo
Browse files Browse the repository at this point in the history
  • Loading branch information
drusco committed Oct 24, 2023
1 parent c14f3cc commit c932f81
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 4 deletions.
23 changes: 23 additions & 0 deletions TODO.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
AJUSTES EN ORDEN DE PRIORIDAD

1. UTILS

**WIP**- dejar claro cuales son los tipos de entrada y salida esperados para cada utilidad.

- simplifica lo que cada util hace, preferentemente una unica cosa

- ajustar los testes unitarios para testar todos los escenarios
posibles de retorno de cada funcion util.


2. LIBS

- dejar claro los tipos de entradas y salida para cada lib method
- simpplificar lo qu cada metodo de la lib hace.
- ajustar testes unitarios para cada método de la lib.


3. ELIMINAR EL USO DE "ANY"

- quitar toda referencia a un tipo de dato any y reemplazar por unknown
- quitar permiso para "any" buscando: @typescript-eslint/no-explicit-any
8 changes: 4 additions & 4 deletions src/utils/constants.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const NO_BREAK = "⁠";
const IS_PROXY_ID_REGEXP = new RegExp(`^${NO_BREAK}\\d+$`);
const HAS_PROXY_ID_REGEXP = new RegExp(`(${NO_BREAK}\\d+)`, "g");
const FUNCTION_TARGET = `${NO_BREAK}function`;
const NO_BREAK: string = "⁠";
const FUNCTION_TARGET: string = `${NO_BREAK}function`;
const IS_PROXY_ID_REGEXP: RegExp = new RegExp(`^${NO_BREAK}\\d+$`);
const HAS_PROXY_ID_REGEXP: RegExp = new RegExp(`(${NO_BREAK}\\d+)`, "g");

export default {
IS_PROXY_ID_REGEXP,
Expand Down

0 comments on commit c932f81

Please sign in to comment.