Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xCluster: Must provide DomainAdministratorCredential #164

Closed
Woogyz opened this issue Dec 22, 2017 · 0 comments · Fixed by #249
Closed

xCluster: Must provide DomainAdministratorCredential #164

Woogyz opened this issue Dec 22, 2017 · 0 comments · Fixed by #249
Labels
enhancement The issue is an enhancement request.

Comments

@Woogyz
Copy link

Woogyz commented Dec 22, 2017

I ran into an issue when utilizing this resource where I didn't want to provide a DA credential. In my environment, we utilize machine identities to ACL most of our resources so we can avoid using passwords in 99.9% of situations. Unfortunately, this resource doesn't support this.
Suggested fixes:

Changed the "DomainAdministratorCredential" property in the schema to "write" (was required).
Changed the "DomainAdministratorCredential" parameter in the resource to "Mandatory = $false".
Wrapped the Set-ImpersonateAs function in an if statement to check for the "DomainAdministratorCredential" key exists in $PSBoundParameters.

@johlju johlju added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Dec 23, 2017
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. and removed in progress The issue is being actively worked on by someone. labels Jun 12, 2019
johlju pushed a commit that referenced this issue Feb 19, 2021
- xCluster
  - Made DomainAdministratorCredential optional (issue #164).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants