From 04d13dc87af0d213c6eb4be9b4c4524e24043148 Mon Sep 17 00:00:00 2001 From: Ben Newman Date: Mon, 30 Dec 2019 11:10:05 -0500 Subject: [PATCH] Use fork of fibers package that triggers GC less often. Apparently calling v8::Isolate::AdjustAmountOfExternalAllocatedMemory frequently results in lots of wasted CPU cycles on garbage collection, per discussion here: meteor/meteor#10527 (comment) This fix was inspired by marudor/libxmljs2#22, which seems to have addressed nodejs/node#30995. Another project that benefitted from adjusting external allocated memory less often: mapnik/node-mapnik#136 --- scripts/dev-bundle-server-package.js | 2 +- scripts/dev-bundle-tool-package.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/dev-bundle-server-package.js b/scripts/dev-bundle-server-package.js index 0787ed90f64..745891d5eac 100644 --- a/scripts/dev-bundle-server-package.js +++ b/scripts/dev-bundle-server-package.js @@ -10,7 +10,7 @@ var packageJson = { dependencies: { // Keep the versions of these packages consistent with the versions // found in dev-bundle-tool-package.js. - fibers: "4.0.2", + fibers: "https://github.com/meteor/node-fibers/tarball/df2c3f135f0f21bfd799eb7f8d33740c0cee6688", "meteor-promise": "0.8.7", promise: "8.0.2", reify: "0.20.12", diff --git a/scripts/dev-bundle-tool-package.js b/scripts/dev-bundle-tool-package.js index c7307b3709a..672511fc29a 100644 --- a/scripts/dev-bundle-tool-package.js +++ b/scripts/dev-bundle-tool-package.js @@ -19,7 +19,7 @@ var packageJson = { // Keep the versions of these packages consistent with the versions // found in dev-bundle-server-package.js. "meteor-promise": "0.8.7", - fibers: "4.0.2", + fibers: "https://github.com/meteor/node-fibers/tarball/df2c3f135f0f21bfd799eb7f8d33740c0cee6688", reify: "0.20.12", // So that Babel can emit require("@babel/runtime/helpers/...") calls. "@babel/runtime": "7.7.6",