Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about the pred noise. #15

Open
northagain opened this issue Apr 10, 2023 · 1 comment
Open

A question about the pred noise. #15

northagain opened this issue Apr 10, 2023 · 1 comment

Comments

@northagain
Copy link

Thanks for ur excellent work!
I have a question about ddim loss which is computed with noise and pred noise.
The pred noise, which is the output of ScheduledCNNRefine Model is >0, because the last activation function is RELU.
However, shouldn't the randn noise contains both >0 parts and <0 parts?
image

@duanyiqun
Copy link
Owner

duanyiqun commented Apr 11, 2023

It is a good question. It should be theoretically right in this case.
Have you tried to use LeakyRelu instead for training? Limited to my memory, I didn't remember a clear difference. But I would appreciate it if you have some comparison results between ReLU and LeadkyReLU. If the results are better, I may have an update. Or we may have a pull request together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants