Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify requires packages (linux, macos) #49

Closed
JAicewizard opened this issue Jul 10, 2024 · 4 comments
Closed

Ability to specify requires packages (linux, macos) #49

JAicewizard opened this issue Jul 10, 2024 · 4 comments

Comments

@JAicewizard
Copy link
Contributor

The FAISS extension requires both a fortran compiler and omp to build, on linux the fortran compiler is lacking and on macos its omp.

On linux the solution should be pretty easy, an extra input with packaged (linux, amd64), packaged (linux, arm64), & packages linux, gcc4) could be provided, to allow for installing any package that is needed for a successful build.

There is a similar situation on macos, where omp is not installed by default, and needs to be installed via brew, I would propose a similar solution of providing per-target dependencies.

I could implement this if needed, is this something that is welcome? It would be really appreciated since the I would like to get the faiss extension in the community repo.

@samansmink
Copy link
Collaborator

Hey @JAicewizard! Thats a good point, I've opened this PR #53. If that merges, I'm happy to merge a PR that adds an optional fortran and omp toolchain.

Note that I will follow up on #53 with a PR to the community extensions repo that allows you to specify which optional toolchains an extension requires, with that the road to adding FAISS to community should be clear

@samansmink
Copy link
Collaborator

Follow up PR here duckdb/community-extensions#50

@samansmink
Copy link
Collaborator

Hey I'm going to close this issue because we have decided to not go down the route of passing custom packages into the reusable workflow. Your options are:

  • make a PR into this repo with a clearly defined set of packages behind a flag, e.g. add parser-tools #56
  • copy the reusable workflow into your extension repo and add them yourself

Note that currently the second option will not allow submitting your extension to the community repo, but we are working on a solution there, see duckdb/community-extensions#73

@JAicewizard
Copy link
Contributor Author

Hey thanks for the comment, I made a new PR that adds fortran and openmp as optional toolchains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants