Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this a Mason package #68

Closed
conradogarciaberrotaran opened this issue Dec 22, 2023 · 4 comments
Closed

Make this a Mason package #68

conradogarciaberrotaran opened this issue Dec 22, 2023 · 4 comments

Comments

@conradogarciaberrotaran

Hi everyone, thank you for this amazing tool. I've been using it for a couple of years now.
I want to include it in my neovim setup, which right now is using Mason as a package manager. I have ruff, black, isort, etc and I'm missing reformat-gherkin to format on save, that would be amazing.

If you're not familiar with Mason, please check this link: https://github.com/williamboman/mason.nvim.
The process of adding it in mason seems to be simple, it's explained here: https://github.com/mason-org/mason-registry?tab=readme-ov-file.
Contributing file seems clear enough: https://github.com/mason-org/mason-registry/blob/main/CONTRIBUTING.md

I wanted to get your approval given than some information for licenses and whatnot are up to you.

What do you think?

@conradogarciaberrotaran
Copy link
Author

For good measure, black's file is here:
https://github.com/mason-org/mason-registry/blob/main/packages/black/package.yaml

@Zeioth
Copy link

Zeioth commented May 10, 2024

@conradogarciaberrotaran Maybe this issue can be closed? I can install reformat-gherkin on mason successfully (and currently I'm PR none-ls to support it).

@conradogarciaberrotaran
Copy link
Author

Closing it.
I'll check your none-ls PR if it's possible, I couldn't find a way to run reformat-gherkin on nvim.

@Zeioth
Copy link

Zeioth commented May 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants