Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict iter.rev() to tests #139

Open
herr-seppia opened this issue Mar 19, 2024 · 0 comments · May be fixed by #140
Open

Restrict iter.rev() to tests #139

herr-seppia opened this issue Mar 19, 2024 · 0 comments · May be fixed by #140
Labels

Comments

@herr-seppia
Copy link
Member

Summary

The presence of iter().rev() primarily serves debugging purposes. This is because, in difficulty derivation, testing against trailing zeros is more user-friendly, as exemplified by let b: [u8; 2] = [0b11110000, 0] rather than let b: [u8; 2] = [0, 0b11110000].

Possible solution design or implementation

removing iter().rev() within the library and restricting it solely to tests.

Additional context

N/A

herr-seppia added a commit that referenced this issue Mar 19, 2024
herr-seppia added a commit that referenced this issue Mar 19, 2024
herr-seppia added a commit that referenced this issue Mar 19, 2024
@herr-seppia herr-seppia linked a pull request Mar 19, 2024 that will close this issue
herr-seppia added a commit that referenced this issue Apr 9, 2024
herr-seppia added a commit that referenced this issue Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant