Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretKey should be enough to verify note's ownership #146

Closed
ZER0 opened this issue Mar 5, 2024 · 2 comments · Fixed by #216
Closed

SecretKey should be enough to verify note's ownership #146

ZER0 opened this issue Mar 5, 2024 · 2 comments · Fixed by #216
Assignees
Labels
type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Milestone

Comments

@ZER0
Copy link
Contributor

ZER0 commented Mar 5, 2024

Summary

We created the ViewKey as a way to delegate the ownership check, however we don't always do that: for example, in the current implementation of the wallet (CLI and web) we're verifying the note locally.
In order to do so, we need to create a ViewKey even if we have access to a SecretKey, that should be enough to verify the note's ownership.

Possible solution design or implementation

As the ViewKey has, the SecretKey should implement the owns method as well.

Additional context

The hope is to reduce not only the code involved, but at least a bit of the operations too.

@HDauven HDauven added the type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) label Apr 10, 2024
@HDauven HDauven added this to the Mainnet milestone Apr 10, 2024
@autholykos
Copy link
Member

@xevisalle @ZER0 is this superseded by the light sync mechanism? Can I close this?

@xevisalle
Copy link
Member

@autholykos it has nothing to do, this is about not requiring the view key to sync if we already have the secret key instantiated. The development is almost done here: #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
4 participants