Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Prover performance regression due to rayon removal from repo #512

Closed
CPerezz opened this issue Apr 21, 2021 · 0 comments
Closed

Fix Prover performance regression due to rayon removal from repo #512

CPerezz opened this issue Apr 21, 2021 · 0 comments
Assignees
@CPerezz
Labels
area:circuit-performance Circuit performance-related topics fix:regression Issues related to fix regression problems team:Core Low Level Core Development Team (Rust)

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Apr 21, 2021

With the removal of rayon from the repo in #495 the proving process suffered from a perf regression and we didn't notice until the benchmarks were coded again in #509.

Therefore, the idea is to bring back just the necessary amount of rayon usage to get back the approximately 30% of performance that was lost there.
@CPerezz CPerezz added area:circuit-performance Circuit performance-related topics fix:regression Issues related to fix regression problems team:Core Low Level Core Development Team (Rust) labels Apr 21, 2021
@CPerezz CPerezz self-assigned this Apr 21, 2021
@CPerezz CPerezz mentioned this issue Apr 21, 2021
Merged
@autholykos autholykos added this to the Port To Canonical 0.6 milestone Apr 22, 2021
@CPerezz CPerezz closed this as completed in 82bbfa8 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPerezz CPerezz

Labels
area:circuit-performance Circuit performance-related topics fix:regression Issues related to fix regression problems team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@autholykos @CPerezz