Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bit_iterator macro #632

Closed
moCello opened this issue Nov 25, 2021 · 4 comments · Fixed by #719
Closed

Remove bit_iterator macro #632

moCello opened this issue Nov 25, 2021 · 4 comments · Fixed by #719
Labels
good first issue Good for newcomers team:Core Low Level Core Development Team (Rust)

Comments

@moCello
Copy link
Member

moCello commented Nov 25, 2021

Describe what you want implemented
Remove the bit_iterator macro.

Describe "Why" this is needed
As far as I can see we only invoke the macro once to create BitIterator8 so I don't see the need to have a macro for it. Creating BitIterator8 directly is much clearer.

Describe alternatives you've considered
Leave as is.

Additional context
NA
@moCello moCello added good first issue Good for newcomers team:Core Low Level Core Development Team (Rust) labels Nov 25, 2021
@ashutoshvarma
Copy link
Contributor

ashutoshvarma commented Jan 12, 2023 •
edited
Loading

Hi, is this still needed? Would be happy to drop a PR for this.

@ashutoshvarma ashutoshvarma mentioned this issue Jan 12, 2023
Merged
@moCello
Copy link
Member Author

moCello commented Jan 16, 2023

Sure! Just add me as a reviewer to the PR

@ashutoshvarma
Copy link
Contributor

@moCello
I'm not able to add you as a reviewer in PR, I think only owner/contributors can do that.
btw here is the PR #719

@moCello
Copy link
Member Author

moCello commented Jan 17, 2023

@ashutoshvarma I see, I'll have a look

@moCello moCello mentioned this issue Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove bit_iterator macro ashutoshvarma/plonk
2 participants
@ashutoshvarma @moCello