Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PIs to the transcript #676

Closed
xevisalle opened this issue Apr 6, 2022 · 0 comments · Fixed by #677
Closed

Add PIs to the transcript #676

xevisalle opened this issue Apr 6, 2022 · 0 comments · Fixed by #677
Assignees
@xevisalle
Labels
area:cryptography anything related to cryptographic primitives, hashing and ZKP fix:vulnerability Issues related to fix vulnerabilities of the architecture or software

Comments

@xevisalle
Copy link
Member

xevisalle commented Apr 6, 2022 •
edited
Loading

Describe the bug
The public inputs should be part of the transcript, as detailed in the plonk paper. This is an important security patch to apply. Thanks to the guys from Trail of Bits to let us know this!
@xevisalle xevisalle added the area:cryptography anything related to cryptographic primitives, hashing and ZKP label Apr 6, 2022
@xevisalle xevisalle linked a pull request Apr 6, 2022 that will close this issue
Add the PIs to the transcript #677
Merged
@xevisalle xevisalle self-assigned this Apr 6, 2022
@xevisalle xevisalle added the fix:vulnerability Issues related to fix vulnerabilities of the architecture or software label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xevisalle xevisalle

Labels
area:cryptography anything related to cryptographic primitives, hashing and ZKP fix:vulnerability Issues related to fix vulnerabilities of the architecture or software
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the PIs to the transcript dusk-network/plonk
1 participant
@xevisalle