Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out potentially offensive combinations #14

Closed
rafal-krypa opened this issue Feb 16, 2023 · 1 comment
Closed

Filter out potentially offensive combinations #14

rafal-krypa opened this issue Feb 16, 2023 · 1 comment

Comments

@rafal-krypa
Copy link

This may be interesting and funny, but I have just actually received holy-crappie from a call to petname.Generate(2, "-"). It happened when using random_pet Terraform resource and now I have AWS resources tagged with that interesting name.
It's not a problem in a test scenario, but I'd prefer to avoid such nasty surprises in production. What do you think about adding a filter for forbidden combinations to the code? I'm not sure how long the "naughty" list would be, but it might be interesting to think about other possible examples.

@dustinkirkland
Copy link
Owner

Hi there!

So there is actually a "naughty" list, in the petname package above this one (python-petname) and the other one (golang-petname). See: https://github.com/dustinkirkland/petname and the debian/blacklist.txt file under that one, which every word in the dictionaries are tested against, at build time. And, yes, that list of bad words is quite long, and most would make you blush...

Generally, I'm happy to add words to the naughty list, and remove them from the usable lists (usually this happens once or twice a year -- see the changelog -- I recently removed "jackass").

But, frankly, I don't think "crappie" is really all that naughty? It's a very common type of fish (actually, my own dad's very favorite fish to catch!). I'm happy to be convinced otherwise, with overwhelming evidence to the contrary. And I'm certainly open to feedback on other words that should be removed.

Thanks! Dustin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants