-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support of goodparts for eslint and prettier users #285
Comments
@92arpitgoyal this would be a great addition/enhancement! 🥇 |
Thanks @nelsonic I have started with https://github.com/92arpitgoyal/eslint-config-goodparts and https://www.npmjs.com/package/eslint-config-goodparts Am I going in right direction? |
@92arpitgoyal the repo you have created looks promising. |
Thanks @nelsonic I will work on testing, can you suggest something for starters? I am new to writing test cases. |
@92arpitgoyal consider taking a look at the tests that @rjans/@eliasCodes wrote for this repo! |
I went through the code, it is using tape as it's framework for testing, will try it and update the codebase. |
@92arpitgoyal have you had a look at https://github.com/dwyl/learn-tape ? |
Hi,
I think it a general issue when a project is already using eslint and/or prettier for linting/styling and don't want to remove them but, want to integrate goodparts.
We can we add a basic info in docs on how to extend existing *rc files to follow goodparts.
So, the idea is to create a repo and a module like https://www.npmjs.com/package/eslint-config-airbnb and whatever equivalent there is for prettier which users can extend and use.
and obviously add it in docs of https://github.com/dwyl/goodparts
The text was updated successfully, but these errors were encountered: