Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support of goodparts for eslint and prettier users #285

Open
92arpitgoyal opened this issue Oct 15, 2018 · 8 comments
Open

adding support of goodparts for eslint and prettier users #285

92arpitgoyal opened this issue Oct 15, 2018 · 8 comments

Comments

@92arpitgoyal
Copy link
Member

92arpitgoyal commented Oct 15, 2018

Hi,

I think it a general issue when a project is already using eslint and/or prettier for linting/styling and don't want to remove them but, want to integrate goodparts.

We can we add a basic info in docs on how to extend existing *rc files to follow goodparts.

So, the idea is to create a repo and a module like https://www.npmjs.com/package/eslint-config-airbnb and whatever equivalent there is for prettier which users can extend and use.

and obviously add it in docs of https://github.com/dwyl/goodparts

@92arpitgoyal
Copy link
Member Author

92arpitgoyal commented Oct 15, 2018

Initial discussions at #53 and #5

@nelsonic
Copy link
Member

@92arpitgoyal this would be a great addition/enhancement! 🥇
if you have time please create a Pull Request! 🎉

@92arpitgoyal
Copy link
Member Author

Thanks @nelsonic

I have started with https://github.com/92arpitgoyal/eslint-config-goodparts and https://www.npmjs.com/package/eslint-config-goodparts

Am I going in right direction?

@nelsonic
Copy link
Member

@92arpitgoyal the repo you have created looks promising.
We found that the most time-consuming part was writing the tests.

@92arpitgoyal
Copy link
Member Author

Thanks @nelsonic I will work on testing, can you suggest something for starters? I am new to writing test cases.

@nelsonic
Copy link
Member

@92arpitgoyal consider taking a look at the tests that @rjans/@eliasCodes wrote for this repo!
They are exemplary of a testing system rather than attempting to write tests individually. 🥇

@92arpitgoyal
Copy link
Member Author

I went through the code, it is using tape as it's framework for testing, will try it and update the codebase.

@nelsonic
Copy link
Member

@92arpitgoyal have you had a look at https://github.com/dwyl/learn-tape ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants