From fa40824acea4131880a001f517dd33a7e5e35c73 Mon Sep 17 00:00:00 2001 From: SimonLab Date: Thu, 22 Sep 2016 14:46:03 +0100 Subject: [PATCH 1/6] test elias rules --- rules/stylistic_issues.js | 2 ++ test/fixtures/stylistic_issues.js | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/rules/stylistic_issues.js b/rules/stylistic_issues.js index 4636d90..e746ba8 100644 --- a/rules/stylistic_issues.js +++ b/rules/stylistic_issues.js @@ -1,4 +1,6 @@ module.exports = { "space-infix-ops": ["error", {"int32Hint": false}], // https://github.com/dwyl/goodparts/issues/32 "max-len": ["error", 80], // https://github.com/dwyl/goodparts/issues/186 + "array-bracket-spacing": ["error", "never"], // https://github.com/dwyl/goodparts/issues/219 + "block-spacing": "error", // https://github.com/dwyl/goodparts/issues/218 }; diff --git a/test/fixtures/stylistic_issues.js b/test/fixtures/stylistic_issues.js index 7156656..9d61cc7 100644 --- a/test/fixtures/stylistic_issues.js +++ b/test/fixtures/stylistic_issues.js @@ -8,5 +8,13 @@ module.exports = { 'space-infix-ops': { fail: ['var a = 1+ 2;'], pass: ['var a = 1 + 2;'] + }, + 'array-bracket-spacing': { + fail: ['[ 1, 2, 3 ]'], + pass: ['[1, 2, 3]'] + }, + 'block-spacing': { + fail: ['{var a =2; }'], + pass: ['{var a =2;}'] } }; From 88a742727b32caefdf1b2cad817e852490e21bb4 Mon Sep 17 00:00:00 2001 From: SimonLab Date: Thu, 22 Sep 2016 15:31:01 +0100 Subject: [PATCH 2/6] add some rules from elias issues --- rules/stylistic_issues.js | 8 ++++++++ test/fixtures/brace-style.fail.js | 6 ++++++ test/fixtures/brace-style.pass.js | 5 +++++ test/fixtures/comma-style.fail.js | 2 ++ test/fixtures/comma-style.pass.js | 2 ++ test/fixtures/eol.fail.js | 3 +++ test/fixtures/eol.pass.js | 3 +++ test/fixtures/stylistic_issues.js | 31 ++++++++++++++++++++++++++++++- 8 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 test/fixtures/brace-style.fail.js create mode 100644 test/fixtures/brace-style.pass.js create mode 100644 test/fixtures/comma-style.fail.js create mode 100644 test/fixtures/comma-style.pass.js create mode 100644 test/fixtures/eol.fail.js create mode 100644 test/fixtures/eol.pass.js diff --git a/rules/stylistic_issues.js b/rules/stylistic_issues.js index e746ba8..9ce3cce 100644 --- a/rules/stylistic_issues.js +++ b/rules/stylistic_issues.js @@ -3,4 +3,12 @@ module.exports = { "max-len": ["error", 80], // https://github.com/dwyl/goodparts/issues/186 "array-bracket-spacing": ["error", "never"], // https://github.com/dwyl/goodparts/issues/219 "block-spacing": "error", // https://github.com/dwyl/goodparts/issues/218 + "brace-style": ["error", "1tbs", { "allowSingleLine": true }], // https://github.com/dwyl/goodparts/issues/217 + "camelcase": "error", // https://github.com/dwyl/goodparts/issues/217 + "comma-style": ["error", "last"], // https://github.com/dwyl/goodparts/issues/216 + "comma-spacing": ["error", { "before": false, "after": true }], // https://github.com/dwyl/goodparts/issues/215 + "comma-dangle": ["error", "never"], // https://github.com/dwyl/goodparts/issues/213 + "computed-property-spacing": ["error", "never"], // https://github.com/dwyl/goodparts/issues/212 + "consistent-this": "off", // https://github.com/dwyl/goodparts/issues/211 + "eol-last": "error", // https://github.com/dwyl/goodparts/issues/210 }; diff --git a/test/fixtures/brace-style.fail.js b/test/fixtures/brace-style.fail.js new file mode 100644 index 0000000..3b76cda --- /dev/null +++ b/test/fixtures/brace-style.fail.js @@ -0,0 +1,6 @@ +if (foo) { + bar(); +} +else { + baz(); +} diff --git a/test/fixtures/brace-style.pass.js b/test/fixtures/brace-style.pass.js new file mode 100644 index 0000000..00e2a38 --- /dev/null +++ b/test/fixtures/brace-style.pass.js @@ -0,0 +1,5 @@ +if (foo) { + bar(); +} else { + baz(); +} diff --git a/test/fixtures/comma-style.fail.js b/test/fixtures/comma-style.fail.js new file mode 100644 index 0000000..0e69905 --- /dev/null +++ b/test/fixtures/comma-style.fail.js @@ -0,0 +1,2 @@ +var foo = 1 + , bar = 2; diff --git a/test/fixtures/comma-style.pass.js b/test/fixtures/comma-style.pass.js new file mode 100644 index 0000000..90f29d6 --- /dev/null +++ b/test/fixtures/comma-style.pass.js @@ -0,0 +1,2 @@ +var foo = 1, + bar = 2; diff --git a/test/fixtures/eol.fail.js b/test/fixtures/eol.fail.js new file mode 100644 index 0000000..ce0b449 --- /dev/null +++ b/test/fixtures/eol.fail.js @@ -0,0 +1,3 @@ +function doSmth() { + var foo = 2; +} \ No newline at end of file diff --git a/test/fixtures/eol.pass.js b/test/fixtures/eol.pass.js new file mode 100644 index 0000000..2802f76 --- /dev/null +++ b/test/fixtures/eol.pass.js @@ -0,0 +1,3 @@ +function doSmth() { + var foo = 2; +} diff --git a/test/fixtures/stylistic_issues.js b/test/fixtures/stylistic_issues.js index 9d61cc7..263f186 100644 --- a/test/fixtures/stylistic_issues.js +++ b/test/fixtures/stylistic_issues.js @@ -16,5 +16,34 @@ module.exports = { 'block-spacing': { fail: ['{var a =2; }'], pass: ['{var a =2;}'] - } + }, + 'brace-style': { + fail: [read('brace-style.fail')], + pass: [read('brace-style.pass')] + }, + 'camelcase': { + fail: ['var camel_case = 42;'], + pass: ['var camelCase = 42;'] + }, + 'comma-style': { + fail: [read('comma-style.fail')], + pass: [read('comma-style.pass')] + }, + 'comma-spacing': { + fail: ['var a = 2 , b = 3;'], + pass: ['var a = 2, b = 3;'] + }, + 'comma-dangle': { + fail: ['var a = [1, 2,];'], + pass: ['var a = [1, 2];'] + }, + 'computed-property-spacing': { + fail: ['obj[ "foo" ];'], + pass: ['obj["foo"];'] + }, + 'consistent-this': null, + 'eol-last': { + fail: [read('eol.fail')], + pass: [read('eol.pass')] + }, }; From 0e4d9ceea0243b5c8feab0a44bddf8fd06d18caa Mon Sep 17 00:00:00 2001 From: SimonLab Date: Thu, 22 Sep 2016 16:17:14 +0100 Subject: [PATCH 3/6] add more rules --- rules/node_common_js.js | 6 ++++++ rules/stylistic_issues.js | 8 ++++++++ rules/variables.js | 4 ++++ test/fixtures/ident.fail.js | 6 ++++++ test/fixtures/ident.pass.js | 6 ++++++ test/fixtures/no-use-before-define.fail.js | 2 ++ test/fixtures/no-use-before-define.pass.js | 2 ++ test/fixtures/node_common_js.js | 13 ++++++++++++- test/fixtures/stylistic_issues.js | 14 ++++++++++++++ test/fixtures/variables.js | 17 ++++++++++++++++- 10 files changed, 76 insertions(+), 2 deletions(-) create mode 100644 test/fixtures/ident.fail.js create mode 100644 test/fixtures/ident.pass.js create mode 100644 test/fixtures/no-use-before-define.fail.js create mode 100644 test/fixtures/no-use-before-define.pass.js diff --git a/rules/node_common_js.js b/rules/node_common_js.js index 7be35b6..b8d20e4 100644 --- a/rules/node_common_js.js +++ b/rules/node_common_js.js @@ -1,2 +1,8 @@ module.exports = { + "no-sync": "off", // https://github.com/dwyl/goodparts/issues/144 + "no-restricted-properties": "off", // https://github.com/dwyl/goodparts/issues/143 + "no-restricted-modules": "off", // https://github.com/dwyl/goodparts/issues/139 + "no-process-exit": "error", // https://github.com/dwyl/goodparts/issues/136 + "no-process-env": "off", // https://github.com/dwyl/goodparts/issues/134 + "no-path-concat": "error", // https://github.com/dwyl/goodparts/issues/132 }; diff --git a/rules/stylistic_issues.js b/rules/stylistic_issues.js index 9ce3cce..9163a2d 100644 --- a/rules/stylistic_issues.js +++ b/rules/stylistic_issues.js @@ -11,4 +11,12 @@ module.exports = { "computed-property-spacing": ["error", "never"], // https://github.com/dwyl/goodparts/issues/212 "consistent-this": "off", // https://github.com/dwyl/goodparts/issues/211 "eol-last": "error", // https://github.com/dwyl/goodparts/issues/210 + "func-call-spacing": ["error", "never"], // https://github.com/dwyl/goodparts/issues/209 + "func-names": "off", // https://github.com/dwyl/goodparts/issues/208 + "func-style": "off", // https://github.com/dwyl/goodparts/issues/207 + "id-blacklist": "off", // https://github.com/dwyl/goodparts/issues/205 + "id-length": "off", // https://github.com/dwyl/goodparts/issues/204 + "id-match": "off", // https://github.com/dwyl/goodparts/issues/202 + "indent": ["error", 4], // https://github.com/dwyl/goodparts/issues/201 + "jsx-quotes": "off", // https://github.com/dwyl/goodparts/issues/199 }; diff --git a/rules/variables.js b/rules/variables.js index 7be35b6..4b1d525 100644 --- a/rules/variables.js +++ b/rules/variables.js @@ -1,2 +1,6 @@ module.exports = { + "no-use-before-define": "error", // https://github.com/dwyl/goodparts/issues/153 + "no-undefined": "error", // https://github.com/dwyl/goodparts/issues/152 + "no-undef-init": "error", // https://github.com/dwyl/goodparts/issues/151 + "no-shadow-restricted-names": "error", // https://github.com/dwyl/goodparts/issues/150 }; diff --git a/test/fixtures/ident.fail.js b/test/fixtures/ident.fail.js new file mode 100644 index 0000000..a7fcbc2 --- /dev/null +++ b/test/fixtures/ident.fail.js @@ -0,0 +1,6 @@ +if (a) { + b=c; + function foo(d) { + e=f; + } +} \ No newline at end of file diff --git a/test/fixtures/ident.pass.js b/test/fixtures/ident.pass.js new file mode 100644 index 0000000..9dc665f --- /dev/null +++ b/test/fixtures/ident.pass.js @@ -0,0 +1,6 @@ +if (a) { + b=c; + function foo(d) { + e=f; + } +} \ No newline at end of file diff --git a/test/fixtures/no-use-before-define.fail.js b/test/fixtures/no-use-before-define.fail.js new file mode 100644 index 0000000..f8d62bf --- /dev/null +++ b/test/fixtures/no-use-before-define.fail.js @@ -0,0 +1,2 @@ +alert(a); +var a = 10; \ No newline at end of file diff --git a/test/fixtures/no-use-before-define.pass.js b/test/fixtures/no-use-before-define.pass.js new file mode 100644 index 0000000..ac6a047 --- /dev/null +++ b/test/fixtures/no-use-before-define.pass.js @@ -0,0 +1,2 @@ +var a = 10; +alert(a); diff --git a/test/fixtures/node_common_js.js b/test/fixtures/node_common_js.js index 95d9b15..0808fd1 100644 --- a/test/fixtures/node_common_js.js +++ b/test/fixtures/node_common_js.js @@ -1,3 +1,14 @@ var read = require('../read.js'); -module.exports = {}; +module.exports = { + 'no-sync': null, + 'no-restricted-properties': null, + 'no-restricted-modules': null, + 'no-process-exit': { + fail: ['process.exit(1);'] + }, + 'no-process-env': null, + 'no-path-concat': { + fail: ['var fullPath = __dirname + "/foo.js";'] + } +}; diff --git a/test/fixtures/stylistic_issues.js b/test/fixtures/stylistic_issues.js index 263f186..20e5198 100644 --- a/test/fixtures/stylistic_issues.js +++ b/test/fixtures/stylistic_issues.js @@ -46,4 +46,18 @@ module.exports = { fail: [read('eol.fail')], pass: [read('eol.pass')] }, + 'func-call-spacing': { + fail: ['fn ();'], + pass: ['fn();'] + }, + 'func-names': null, + 'func-style': null, + 'id-blacklist': null, + 'id-length': null, + 'id-match': null, + 'indent': { + fail: [read('ident.fail')], + pass: [read('ident.pass')] + }, + 'jsx-quotes': null }; diff --git a/test/fixtures/variables.js b/test/fixtures/variables.js index 95d9b15..dcf00f8 100644 --- a/test/fixtures/variables.js +++ b/test/fixtures/variables.js @@ -1,3 +1,18 @@ var read = require('../read.js'); -module.exports = {}; +module.exports = { + 'no-use-before-define': { + fail: [read('no-use-before-define.fail')], + pass: [read('no-use-before-define.pass')] + }, + 'no-undefined': { + fail: ['var undefined = "bob";'] + }, + 'no-undef-init': { + fail: ['var a = undefined;'], + pass: ['var a;'] + }, + 'no-shadow-restricted-names': { + fail: ['function NaN(){};'] + } +}; From a980d5d1c70ffbf445786bd7013ee4586bc1df3c Mon Sep 17 00:00:00 2001 From: SimonLab Date: Thu, 22 Sep 2016 16:55:58 +0100 Subject: [PATCH 4/6] more rules! --- rules/node_common_js.js | 5 +++++ test/fixtures/callback-return.fail.js | 5 +++++ test/fixtures/callback-return.pass.js | 5 +++++ test/fixtures/global-require.fail.js | 5 +++++ test/fixtures/handle-callback-err.fail.js | 3 +++ test/fixtures/handle-callback-err.pass.js | 6 ++++++ test/fixtures/no-mixed-requires.fail.js | 2 ++ test/fixtures/node_common_js.js | 17 +++++++++++++++++ 8 files changed, 48 insertions(+) create mode 100644 test/fixtures/callback-return.fail.js create mode 100644 test/fixtures/callback-return.pass.js create mode 100644 test/fixtures/global-require.fail.js create mode 100644 test/fixtures/handle-callback-err.fail.js create mode 100644 test/fixtures/handle-callback-err.pass.js create mode 100644 test/fixtures/no-mixed-requires.fail.js diff --git a/rules/node_common_js.js b/rules/node_common_js.js index b8d20e4..25860eb 100644 --- a/rules/node_common_js.js +++ b/rules/node_common_js.js @@ -5,4 +5,9 @@ module.exports = { "no-process-exit": "error", // https://github.com/dwyl/goodparts/issues/136 "no-process-env": "off", // https://github.com/dwyl/goodparts/issues/134 "no-path-concat": "error", // https://github.com/dwyl/goodparts/issues/132 + "no-new-require": "error", // https://github.com/dwyl/goodparts/issues/129 + "no-mixed-requires": ["error", { "grouping": true, "allowCall": false }], // https://github.com/dwyl/goodparts/issues/126 + "handle-callback-err": ["error", "^(error|err\d*)$"], // https://github.com/dwyl/goodparts/issues/121 + "global-require": "error", // https://github.com/dwyl/goodparts/issues/119 + "callback-return": ["error", ["done", "next", "callback", "cb"]], // https://github.com/dwyl/goodparts/issues/112 }; diff --git a/test/fixtures/callback-return.fail.js b/test/fixtures/callback-return.fail.js new file mode 100644 index 0000000..98842dc --- /dev/null +++ b/test/fixtures/callback-return.fail.js @@ -0,0 +1,5 @@ +function foo(err, callback) { + if (err) { + callback(err); + } +} \ No newline at end of file diff --git a/test/fixtures/callback-return.pass.js b/test/fixtures/callback-return.pass.js new file mode 100644 index 0000000..7f1b051 --- /dev/null +++ b/test/fixtures/callback-return.pass.js @@ -0,0 +1,5 @@ +function foo(err, callback) { + if (err) { + return callback(err); + } +} \ No newline at end of file diff --git a/test/fixtures/global-require.fail.js b/test/fixtures/global-require.fail.js new file mode 100644 index 0000000..7378d7f --- /dev/null +++ b/test/fixtures/global-require.fail.js @@ -0,0 +1,5 @@ +function foo() { + if (condition) { + var fs = require("fs"); + } +} \ No newline at end of file diff --git a/test/fixtures/handle-callback-err.fail.js b/test/fixtures/handle-callback-err.fail.js new file mode 100644 index 0000000..0921247 --- /dev/null +++ b/test/fixtures/handle-callback-err.fail.js @@ -0,0 +1,3 @@ +function loadData (err, data) { + doSomething(); +} diff --git a/test/fixtures/handle-callback-err.pass.js b/test/fixtures/handle-callback-err.pass.js new file mode 100644 index 0000000..3f2c375 --- /dev/null +++ b/test/fixtures/handle-callback-err.pass.js @@ -0,0 +1,6 @@ +function loadData (err, data) { + if (err) { + console.log(err.stack); + } + doSomething(); +} \ No newline at end of file diff --git a/test/fixtures/no-mixed-requires.fail.js b/test/fixtures/no-mixed-requires.fail.js new file mode 100644 index 0000000..d622ed1 --- /dev/null +++ b/test/fixtures/no-mixed-requires.fail.js @@ -0,0 +1,2 @@ +var fs = require('fs'), + async = require('async'); \ No newline at end of file diff --git a/test/fixtures/node_common_js.js b/test/fixtures/node_common_js.js index 0808fd1..d14f855 100644 --- a/test/fixtures/node_common_js.js +++ b/test/fixtures/node_common_js.js @@ -10,5 +10,22 @@ module.exports = { 'no-process-env': null, 'no-path-concat': { fail: ['var fullPath = __dirname + "/foo.js";'] + }, + 'no-new-require': { + fail: ['var mod = new require("mod");'] + }, + 'no-mixed-requires': { + fail: [read('no-mixed-requires.fail')], + }, + 'handle-callback-err': { + fail: [read('handle-callback-err.fail')], + pass: [read('handle-callback-err.pass')] + }, + 'global-require': { + fail: [read('global-require.fail')] + }, + 'callback-return': { + fail: [read('callback-return.fail')], + pass: [read('callback-return.pass')] } }; From 46b50c51b12ab59092d52919494ecf46538e8c22 Mon Sep 17 00:00:00 2001 From: SimonLab Date: Thu, 22 Sep 2016 17:21:32 +0100 Subject: [PATCH 5/6] first version of elias rules --- rules/stylistic_issues.js | 9 +++++++++ test/fixtures/padded-blocks.fail.js | 5 +++++ test/fixtures/padded-blocks.pass.js | 3 +++ test/fixtures/quote-props.fail.js | 4 ++++ test/fixtures/quote-props.pass.js | 4 ++++ test/fixtures/quotes.fail.js | 1 + test/fixtures/quotes.pass.js | 1 + test/fixtures/stylistic_issues.js | 29 ++++++++++++++++++++++++++++- 8 files changed, 55 insertions(+), 1 deletion(-) create mode 100644 test/fixtures/padded-blocks.fail.js create mode 100644 test/fixtures/padded-blocks.pass.js create mode 100644 test/fixtures/quote-props.fail.js create mode 100644 test/fixtures/quote-props.pass.js create mode 100644 test/fixtures/quotes.fail.js create mode 100644 test/fixtures/quotes.pass.js diff --git a/rules/stylistic_issues.js b/rules/stylistic_issues.js index 9163a2d..6f56d0e 100644 --- a/rules/stylistic_issues.js +++ b/rules/stylistic_issues.js @@ -19,4 +19,13 @@ module.exports = { "id-match": "off", // https://github.com/dwyl/goodparts/issues/202 "indent": ["error", 4], // https://github.com/dwyl/goodparts/issues/201 "jsx-quotes": "off", // https://github.com/dwyl/goodparts/issues/199 + "padded-blocks": ["error", "never"], // https://github.com/dwyl/goodparts/issues/55 + "quote-props": ["error", "consistent-as-needed", { "keywords": false }], // https://github.com/dwyl/goodparts/issues/54 + "quotes": ["error", "single", {"avoidEscape": false, "allowTemplateLiterals": false}], // https://github.com/dwyl/goodparts/issues/53 + "semi-spacing": ["error", {"before": false, "after": true}], // https://github.com/dwyl/goodparts/issues/50 + "sort-keys": "off", // https://github.com/dwyl/goodparts/issues/39 + "sort-vars": "off", // https://github.com/dwyl/goodparts/issues/38 + "space-in-parens": ["error", "never"], // https://github.com/dwyl/goodparts/issues/34 + "spaced-comment": ["error", "always"], // https://github.com/dwyl/goodparts/issues/20 + "wrap-regex": "off" // https://github.com/dwyl/goodparts/issues/20 }; diff --git a/test/fixtures/padded-blocks.fail.js b/test/fixtures/padded-blocks.fail.js new file mode 100644 index 0000000..a80b675 --- /dev/null +++ b/test/fixtures/padded-blocks.fail.js @@ -0,0 +1,5 @@ +if (a) { + + b(); + +} \ No newline at end of file diff --git a/test/fixtures/padded-blocks.pass.js b/test/fixtures/padded-blocks.pass.js new file mode 100644 index 0000000..2f7a016 --- /dev/null +++ b/test/fixtures/padded-blocks.pass.js @@ -0,0 +1,3 @@ +if (a) { + b(); +} \ No newline at end of file diff --git a/test/fixtures/quote-props.fail.js b/test/fixtures/quote-props.fail.js new file mode 100644 index 0000000..7003264 --- /dev/null +++ b/test/fixtures/quote-props.fail.js @@ -0,0 +1,4 @@ +var object = { + "foo": 'bar', + baz: 42 +}; \ No newline at end of file diff --git a/test/fixtures/quote-props.pass.js b/test/fixtures/quote-props.pass.js new file mode 100644 index 0000000..f4dbbe6 --- /dev/null +++ b/test/fixtures/quote-props.pass.js @@ -0,0 +1,4 @@ +var object = { + foo: 'bar', + baz: 42 +}; \ No newline at end of file diff --git a/test/fixtures/quotes.fail.js b/test/fixtures/quotes.fail.js new file mode 100644 index 0000000..717e3d9 --- /dev/null +++ b/test/fixtures/quotes.fail.js @@ -0,0 +1 @@ +var double = "double"; \ No newline at end of file diff --git a/test/fixtures/quotes.pass.js b/test/fixtures/quotes.pass.js new file mode 100644 index 0000000..30af391 --- /dev/null +++ b/test/fixtures/quotes.pass.js @@ -0,0 +1 @@ +var nodouble = 'double'; \ No newline at end of file diff --git a/test/fixtures/stylistic_issues.js b/test/fixtures/stylistic_issues.js index 20e5198..fe3e738 100644 --- a/test/fixtures/stylistic_issues.js +++ b/test/fixtures/stylistic_issues.js @@ -59,5 +59,32 @@ module.exports = { fail: [read('ident.fail')], pass: [read('ident.pass')] }, - 'jsx-quotes': null + 'jsx-quotes': null, + 'padded-blocks': { + fail: [read('padded-blocks.fail')], + pass: [read('padded-blocks.pass')] + }, + 'quote-props': { + fail: [read('quote-props.fail')], + pass: [read('quote-props.pass')] + }, + 'quotes': { + fail: [read('quotes.fail')], + pass: [read('quotes.pass')] + }, + 'semi-spacing': { + fail: ['var a = 2 ;', 'var foo;var bar;'], + pass: ['var a = 2;', 'var foo; var bar;'] + }, + 'sort-keys': null, + 'sort-vars': null, + 'space-in-parens': { + fail: ['foo( "bar" );'], + pass: ['foo("ba");'] + }, + 'spaced-comment': { + fail: ['//no space'], + pass: ['// yes!'] + }, + 'wrap-regex': null }; From 22500ff8aec39d35e9b8d014cab0ee8e80cd665f Mon Sep 17 00:00:00 2001 From: SimonLab Date: Fri, 23 Sep 2016 08:49:38 +0100 Subject: [PATCH 6/6] update comment related issue --- rules/stylistic_issues.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/rules/stylistic_issues.js b/rules/stylistic_issues.js index 7a24317..97176d7 100644 --- a/rules/stylistic_issues.js +++ b/rules/stylistic_issues.js @@ -4,9 +4,9 @@ module.exports = { "array-bracket-spacing": ["error", "never"], // https://github.com/dwyl/goodparts/issues/219 "block-spacing": "error", // https://github.com/dwyl/goodparts/issues/218 "brace-style": ["error", "1tbs", { "allowSingleLine": true }], // https://github.com/dwyl/goodparts/issues/217 - "camelcase": "error", // https://github.com/dwyl/goodparts/issues/217 - "comma-style": ["error", "last"], // https://github.com/dwyl/goodparts/issues/216 - "comma-spacing": ["error", { "before": false, "after": true }], // https://github.com/dwyl/goodparts/issues/215 + "camelcase": "error", // https://github.com/dwyl/goodparts/issues/216 + "comma-style": ["error", "last"], // https://github.com/dwyl/goodparts/issues/215 + "comma-spacing": ["error", { "before": false, "after": true }], // https://github.com/dwyl/goodparts/issues/214 "comma-dangle": ["error", "never"], // https://github.com/dwyl/goodparts/issues/213 "computed-property-spacing": ["error", "never"], // https://github.com/dwyl/goodparts/issues/212 "consistent-this": "off", // https://github.com/dwyl/goodparts/issues/211 @@ -27,7 +27,7 @@ module.exports = { "sort-vars": "off", // https://github.com/dwyl/goodparts/issues/38 "space-in-parens": ["error", "never"], // https://github.com/dwyl/goodparts/issues/34 "spaced-comment": ["error", "always"], // https://github.com/dwyl/goodparts/issues/20 - "wrap-regex": "off", // https://github.com/dwyl/goodparts/issues/20 + "wrap-regex": "off", // https://github.com/dwyl/goodparts/issues/17 "max-len": ["error", { code: 80, ignoreTrailingComments: true,