Fix catch block parsing #1030
Merged
Fix catch block parsing #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e value. SymtabAPI uses a 8-byte integer and properly clip the value when reading it. However, there is an add to the read value, which will cause the final result to wrap around under its specified size (such as 4-byte), but not under 8-byte.
|
@hainest Since you are out next week, I would like to get this fixed this week. While Sasha is reviewing my change, can you also get it a test suite run? |
|
@sashanicolas Do you have concern on merging this PR? |
|
Looks good. |
sashanicolas
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause is that SymtabAPI uses a 8-byte value to read catch block addresses, which can be a 2, 4 or 8-byte value. While we are careful to clip the value when reading it, there is an addition to it later where we did not clip the value according to its size.
Fixes #1027